Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755463Ab2K3Vmi (ORCPT ); Fri, 30 Nov 2012 16:42:38 -0500 Received: from mail-la0-f46.google.com ([209.85.215.46]:37309 "EHLO mail-la0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751952Ab2K3Vmg (ORCPT ); Fri, 30 Nov 2012 16:42:36 -0500 MIME-Version: 1.0 In-Reply-To: References: <507FD39F.4060601@citrix.com> <1350554618-14582-3-git-send-email-david.vrabel@citrix.com> <20121019125919.GC26830@phenom.dumpdata.com> From: Bjorn Helgaas Date: Fri, 30 Nov 2012 14:42:14 -0700 Message-ID: Subject: Re: [PATCH 3/5] xen-pcifront: handle backend CLOSED without CLOSING To: Konrad Rzeszutek Wilk Cc: David Vrabel , xen-devel@lists.xen.org, linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2465 Lines: 61 On Fri, Nov 30, 2012 at 11:41 AM, Bjorn Helgaas wrote: > On Fri, Oct 19, 2012 at 6:59 AM, Konrad Rzeszutek Wilk > wrote: >> On Thu, Oct 18, 2012 at 11:03:36AM +0100, David Vrabel wrote: >>> From: David Vrabel >>> >>> Backend drivers shouldn't transistion to CLOSED unless the frontend is >>> CLOSED. If a backend does transition to CLOSED too soon then the >>> frontend may not see the CLOSING state and will not properly shutdown. >>> >>> So, treat an unexpected backend CLOSED state the same as CLOSING. >>> >>> Signed-off-by: David Vrabel >>> Acked-by: Konrad Rzeszutek Wilk >>> --- >>> Cc: linux-pci@vger.kernel.org >>> Cc: Bjorn Helgaas >> >> Bjorn, do you want me to prep a git pull with this patch >> or can I have your Ack to put it my tree and have it part of my >> git pull to Linus? > > Sorry, I missed this. I can put it in my -next branch for the v3.8 > merge window. Would that work for you? I put this in my -next branch, so we'll at least have a chance of making a linux-next cycle before v3.7 pops. >>> --- >>> drivers/pci/xen-pcifront.c | 5 ++++- >>> 1 files changed, 4 insertions(+), 1 deletions(-) >>> >>> diff --git a/drivers/pci/xen-pcifront.c b/drivers/pci/xen-pcifront.c >>> index 0aab85a..a0c7312 100644 >>> --- a/drivers/pci/xen-pcifront.c >>> +++ b/drivers/pci/xen-pcifront.c >>> @@ -1068,13 +1068,16 @@ static void __init_refok pcifront_backend_changed(struct xenbus_device *xdev, >>> case XenbusStateInitialising: >>> case XenbusStateInitWait: >>> case XenbusStateInitialised: >>> - case XenbusStateClosed: >>> break; >>> >>> case XenbusStateConnected: >>> pcifront_try_connect(pdev); >>> break; >>> >>> + case XenbusStateClosed: >>> + if (xdev->state == XenbusStateClosed) >>> + break; >>> + /* Missed the backend's CLOSING state -- fallthrough */ >>> case XenbusStateClosing: >>> dev_warn(&xdev->dev, "backend going away!\n"); >>> pcifront_try_disconnect(pdev); >>> -- >>> 1.7.2.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/