Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751823Ab3CAFMs (ORCPT ); Fri, 1 Mar 2013 00:12:48 -0500 Received: from mga09.intel.com ([134.134.136.24]:36321 "EHLO mga09.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750798Ab3CAFMr convert rfc822-to-8bit (ORCPT ); Fri, 1 Mar 2013 00:12:47 -0500 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.84,759,1355126400"; d="scan'208";a="292155484" From: "R, Durgadoss" To: Eduardo Valentin CC: "Zhang, Rui" , "linux-pm@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hongbo.zhang@linaro.org" , "wni@nvidia.com" Subject: RE: [PATCHv3 0/8] Thermal Framework Enhancements Thread-Topic: [PATCHv3 0/8] Thermal Framework Enhancements Thread-Index: AQHOA47bkatPNHy0BkSONsxAJ+BJCZiPk0QAgADbffA= Date: Fri, 1 Mar 2013 05:12:29 +0000 Message-ID: <4D68720C2E767A4AA6A8796D42C8EB59292A35@BGSMSX101.gar.corp.intel.com> References: <1360061183-14137-1-git-send-email-durgadoss.r@intel.com> <512FCD3C.1020504@ti.com> In-Reply-To: <512FCD3C.1020504@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.223.10.10] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1698 Lines: 49 Hi Eduardo, > -----Original Message----- > From: Eduardo Valentin [mailto:eduardo.valentin@ti.com] > Sent: Friday, March 01, 2013 3:04 AM > To: R, Durgadoss > Cc: Zhang, Rui; linux-pm@vger.kernel.org; linux-kernel@vger.kernel.org; > hongbo.zhang@linaro.org; wni@nvidia.com > Subject: Re: [PATCHv3 0/8] Thermal Framework Enhancements > > > Durga, > > > > On 05-02-2013 06:46, Durgadoss R wrote: > > This patch set is a v3 of the previous versions submitted here: > > [v2]: http://lwn.net/Articles/531720/ > > [v1]: https://lkml.org/lkml/2012/12/18/108 > > [RFC]:https://patchwork.kernel.org/patch/1758921/ > > On this version I have some implementation details which applies mostly > for the series. So, I am replying to patch 0 to summarize: > > - Consider using linked list This I thought through on my RFC itself. I know we have arrays, but using list adds too many members to the structures, and protection becomes really cryptic. > - You may have contention on your indexes and arrays > - overflow on your buffer (carefully check your implementation) > - zone removal condition. can we remove zones with sensors/cdevs/maps > registered? > - Minors on strlcpy, snprintf, devm_ helpers > - documentation in the code for these helper functions and also better > naming.. I will try to take care of these in my next version, as far as I can see. But would really help if you can point the specific code that needs improvement. Thanks, Durga -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/