Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751060Ab3CAMuZ (ORCPT ); Fri, 1 Mar 2013 07:50:25 -0500 Received: from slimlogic.co.uk ([89.16.172.20]:53669 "EHLO slimlogic.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750708Ab3CAMuY (ORCPT ); Fri, 1 Mar 2013 07:50:24 -0500 Message-ID: <5130A3FD.3030207@slimlogic.co.uk> Date: Fri, 01 Mar 2013 12:50:05 +0000 From: Ian Lartey User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: Mark Brown , Graeme Gregory , "linux-kernel@vger.kernel.org" , Stephen Warren , "lrg@ti.com" Subject: Re: [PATCH] regulator: palmas: use correct device node for DT parsing References: <1361974224-18180-1-git-send-email-ldewangan@nvidia.com> <512E16EE.2050201@slimlogic.co.uk> <20130301063915.GD25302@opensource.wolfsonmicro.com> <5130A303.4060909@nvidia.com> In-Reply-To: <5130A303.4060909@nvidia.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2290 Lines: 56 On 01/03/13 12:45, Laxman Dewangan wrote: > On Friday 01 March 2013 12:09 PM, Mark Brown wrote: >> * PGP Signed by an unknown key >> >> On Wed, Feb 27, 2013 at 02:23:42PM +0000, Graeme Gregory wrote: >>> On 27/02/13 14:10, Laxman Dewangan wrote: >>>> When device is registered through the DT then regulators node >>>> exist in the parent device node of regulator driver. Hence passing >>>> parent device node for parsing DT in place of self-device node >>>> which is typically NULL. >>>> - struct device_node *node = pdev->dev.of_node; >>>> + struct device_node *node = pdev->dev.parent->of_node; >>> This is not correct, nor is the reasoning. >>> I suspect your previous patch broke DT probing so your not getting nodes >>> filled in. >> So, the reason that this pattern has generally been followed is so that >> the regulator core can do the equivalent of regulator_get(dev, supply) >> to find the supplies. Using the parent device there is particularly >> important in non-DT systems so that we can map the child regulator >> supply in by using the dev_name() of the parent rather than the MFD >> internal subdevice name but for pure DT systems where it's all just >> direct links it's less of an issue. >> >> > > If I make the dts file as > #gpio-cells = <2>; > gpio-controller; > > palmas_pmic { > compatible = "ti,palmas-pmic"; > ti,ldo6_vibrator = <0>; > > regulators { > ::::::::::::: > } > } > > > then regulator get registered properly. > And hence this patch is not require here. > Yes that would do it. > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/