Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751052Ab3CANLc (ORCPT ); Fri, 1 Mar 2013 08:11:32 -0500 Received: from mail-lb0-f175.google.com ([209.85.217.175]:42218 "EHLO mail-lb0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750696Ab3CANLb (ORCPT ); Fri, 1 Mar 2013 08:11:31 -0500 Message-ID: <5130A8DF.7080709@cogentembedded.com> Date: Fri, 01 Mar 2013 17:10:55 +0400 From: Sergei Shtylyov Organization: Cogent Embedded User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Aaron Lu CC: Jeff Garzik , Tejun Heo , Linus Torvalds , "linux-ide@vger.kernel.org" , Jeff Garzik , "Rafael J. Wysocki" , LKML , Linux PM list Subject: Re: [PATCH] [libata] Avoid specialized TLA's in ZPODD's Kconfig References: <1663657.ypAtqGpGAq@vostro.rjw.lan> <1781256.mPQbtiUPYR@vostro.rjw.lan> <2223198.XmyRLgb3Gv@vostro.rjw.lan> <20130226161049.GA9303@kahuna> <20130226163712.GA30433@htj.dyndns.org> <20130226165813.GB30433@htj.dyndns.org> <512CF809.8010102@pobox.com> <5130052E.9070403@intel.com> In-Reply-To: <5130052E.9070403@intel.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1815 Lines: 53 Hello. On 01-03-2013 5:32, Aaron Lu wrote: > ODD is not a common TLA for non-ATA people so they will get confused > by its meaning when they are configuring the kernel. This patch fixed > this problem by using ODD only after stating what it is. > Signed-off-by: Aaron Lu > --- > drivers/ata/Kconfig | 13 +++++++------ > 1 file changed, 7 insertions(+), 6 deletions(-) > diff --git a/drivers/ata/Kconfig b/drivers/ata/Kconfig > index 3e751b7..d7d210e 100644 > --- a/drivers/ata/Kconfig > +++ b/drivers/ata/Kconfig > @@ -59,15 +59,16 @@ config ATA_ACPI > option libata.noacpi=1 > > config SATA_ZPODD > - bool "SATA Zero Power ODD Support" > + bool "SATA Zero Power Optical Disc Drive(ZPODD) support" Need a space before open paren. > depends on ATA_ACPI > default n > help > - This option adds support for SATA ZPODD. It requires both > - ODD and the platform support, and if enabled, will automatically > - power on/off the ODD when certain condition is satisfied. This > - does not impact user's experience of the ODD, only power is saved > - when ODD is not in use(i.e. no disc inside). > + This option adds support for SATA Zero Power Optical Disc > + Drive(ZPODD). It requires both the ODD and the platform Same here. > + support, and if enabled, will automatically power on/off the > + ODD when certain condition is satisfied. This does not impact > + end user's experience of the ODD, only power is saved when > + the ODD is not in use(i.e. no disc inside). And here. MBR, Sergei -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/