Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752082Ab3CBEla (ORCPT ); Fri, 1 Mar 2013 23:41:30 -0500 Received: from mail-ie0-f174.google.com ([209.85.223.174]:64906 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751381Ab3CBEl3 (ORCPT ); Fri, 1 Mar 2013 23:41:29 -0500 MIME-Version: 1.0 In-Reply-To: <1362183404.3420.25.camel@buesod1.americas.hpqcorp.net> References: <1362183404.3420.25.camel@buesod1.americas.hpqcorp.net> Date: Sat, 2 Mar 2013 12:41:28 +0800 Message-ID: Subject: Re: [PATCH 2/2] ipc: semaphores: do not hold ipc lock more than necessary From: Michel Lespinasse To: Davidlohr Bueso Cc: Linus Torvalds , Rik van Riel , "Vinod, Chegu" , "Low, Jason" , linux-tip-commits@vger.kernel.org, Peter Zijlstra , "H. Peter Anvin" , Andrew Morton , aquini@redhat.com, Ingo Molnar , Larry Woodman , Linux Kernel Mailing List , Steven Rostedt , Thomas Gleixner Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 829 Lines: 23 On Sat, Mar 2, 2013 at 8:16 AM, Davidlohr Bueso wrote: > Instead of holding the ipc lock for permissions and security > checks, among others, only acquire it when necessary. > > Signed-off-by: Davidlohr Bueso You got some really great test results on this; I think they deserve to be mentioned in the commit message. Code looks fine to me otherwise, but I only had a quick look. Nice work! Acked-by: Michel Lespinasse -- Michel "Walken" Lespinasse A program is never fully debugged until the last user dies. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/