Date: Sat, 2 Mar 2013 21:23:30 +0800
From: Fengguang Wu <fengguang.wu@intel.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: LKML <linux-kernel@vger.kernel.org>, Christopher Li <sparse@chrisli.org>
Subject: Re: [trace:tip/perf/core 5/15] kernel/trace/trace_functions.c:79:16:
 sparse: incorrect type in initializer (different address spaces)
Message-ID: <20130302132330.GA15256@localhost>
References: <5131ad43.H709l5IR4X+pbvbq%fengguang.wu@intel.com>
 <1362229972.31874.7.camel@gandalf.local.home>
 <1362230122.31874.8.camel@gandalf.local.home>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1362230122.31874.8.camel@gandalf.local.home>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1183
Lines: 38

On Sat, Mar 02, 2013 at 08:15:22AM -0500, Steven Rostedt wrote:
> On Sat, 2013-03-02 at 08:12 -0500, Steven Rostedt wrote:
> 
> > Hmm, actually it seems to be complaining everywhere but in trace.c which
> > is where the per_cpu was allocated. Do I need to annotate the trace.h
> > header to specify (at least to sparse) that the pointer is allocated per
> > cpu?
> 
> I guess I need this patch:

That's it!  Verified with

        make C=1 kernel/trace/trace_functions.o

Thanks,
Fengguang

> diff --git a/kernel/trace/trace.h b/kernel/trace/trace.h
> index c597523..50a9c81 100644
> --- a/kernel/trace/trace.h
> +++ b/kernel/trace/trace.h
> @@ -198,7 +198,7 @@ struct trace_array {
>         struct list_head        systems;
>         struct list_head        events;
>         struct task_struct      *waiter;
> -       struct trace_array_cpu  *data;
> +       struct trace_array_cpu __percpu *data;
>  };
>  
>  enum {
> 
> -- Steve
> 
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/