Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752698Ab3CBVRB (ORCPT ); Sat, 2 Mar 2013 16:17:01 -0500 Received: from g4t0015.houston.hp.com ([15.201.24.18]:2093 "EHLO g4t0015.houston.hp.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752563Ab3CBVRA (ORCPT ); Sat, 2 Mar 2013 16:17:00 -0500 Message-ID: <1362259010.3602.4.camel@buesod1.americas.hpqcorp.net> Subject: Re: [PATCH 2/2] ipc: semaphores: do not hold ipc lock more than necessary From: Davidlohr Bueso To: Michel Lespinasse Cc: Linus Torvalds , Rik van Riel , "Vinod, Chegu" , "Low, Jason" , linux-tip-commits@vger.kernel.org, Peter Zijlstra , "H. Peter Anvin" , Andrew Morton , aquini@redhat.com, Ingo Molnar , Larry Woodman , Linux Kernel Mailing List , Steven Rostedt , Thomas Gleixner Date: Sat, 02 Mar 2013 13:16:50 -0800 In-Reply-To: References: <1362183404.3420.25.camel@buesod1.americas.hpqcorp.net> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 885 Lines: 29 On Sat, 2013-03-02 at 12:41 +0800, Michel Lespinasse wrote: > On Sat, Mar 2, 2013 at 8:16 AM, Davidlohr Bueso wrote: > > Instead of holding the ipc lock for permissions and security > > checks, among others, only acquire it when necessary. > > > > Signed-off-by: Davidlohr Bueso > > You got some really great test results on this; I think they deserve > to be mentioned in the commit message. Absolutely. > > Code looks fine to me otherwise, but I only had a quick look. > > Nice work! > > Acked-by: Michel Lespinasse > Thanks for reviewing, Michel. Davidlohr -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/