Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752762Ab3CCGoR (ORCPT ); Sun, 3 Mar 2013 01:44:17 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:48313 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750846Ab3CCGoP (ORCPT ); Sun, 3 Mar 2013 01:44:15 -0500 Date: Sun, 03 Mar 2013 01:44:14 -0500 (EST) Message-Id: <20130303.014414.674265878687150706.davem@davemloft.net> To: freddy@asix.com.tw Cc: netdev@vger.kernel.org, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, louis@asix.com.tw Subject: Re: [PATCH resubmit] ax88179_178a: ASIX AX88179_178A USB 3.0/2.0 to gigabit ethernet adapter driver From: David Miller In-Reply-To: <1362220871-2395-1-git-send-email-freddy@asix.com.tw> References: <1362220871-2395-1-git-send-email-freddy@asix.com.tw> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Sat, 02 Mar 2013 22:44:19 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1777 Lines: 34 From: Freddy Xin Date: Sat, 2 Mar 2013 18:41:11 +0800 > From: Freddy Xin > > This is a resubmission. > Added kfree() in ax88179_get_eeprom to prevent memory leakage. > Modified "__le16 rxctl" to "u16 rxctl" in "struct ax88179_data" and removed pointless casts. > Removed asix_init and asix_exit functions and added "module_usb_driver(ax88179_178a_driver)". > Fixed endianness issue on big endian systems and verified this driver on iBook G4. > Removed steps that change net->features in ax88179_set_features function. > Added "const" to ethtool_ops structure and fixed the coding style of AX88179_BULKIN_SIZE array. > Fixed the issue that the default MTU is not 1500. > Added ax88179_change_mtu function and enabled the hardware jumbo frame function to support an > MTU higher than 1500. > Fixed indentation and empty line coding style errors. > The _nopm version usb functions were added to access register in suspend and resume functions. > Serveral variables allocted dynamically were removed and replaced by stack variables. > ax88179_get_eeprom were modified from asix_get_eeprom in asix_common. > > This patch adds a driver for ASIX's AX88179 family of USB 3.0/2.0 > to gigabit ethernet adapters. It's based on the AX88xxx driver but > the usb commands used to access registers for AX88179 are completely different. > This driver had been verified on x86 system with AX88179/AX88178A and > Sitcomm LN-032 USB dongles. > > Signed-off-by: Freddy Xin Applied. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/