Message-ID: <1362306002.1334.29.camel@x61.thuisdomein>
Subject: Re: [ 34/77] xen/blkback: Dont trust the handle from the frontend.
From: Paul Bolle <pebolle@tiscali.nl>
To: Ben Hutchings <ben@decadent.org.uk>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, stable@vger.kernel.org,
        Jan Beulich <jbeulich@suse.com>,
        Ian Campbell <ian.campbell@citrix.com>,
        Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
Date: Sun, 03 Mar 2013 11:20:02 +0100
In-Reply-To: <1362265843.3768.162.camel@deadeye.wl.decadent.org.uk>
References: <20130301194351.913471337@linuxfoundation.org>
	 <20130301194355.578429064@linuxfoundation.org>
	 <1362172344.20156.15.camel@x61.thuisdomein>
	 <1362253682.3768.136.camel@deadeye.wl.decadent.org.uk>
	 <1362263724.1334.18.camel@x61.thuisdomein>
	 <1362265843.3768.162.camel@deadeye.wl.decadent.org.uk>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 904
Lines: 24

On Sat, 2013-03-02 at 23:10 +0000, Ben Hutchings wrote:
> On Sat, 2013-03-02 at 23:35 +0100, Paul Bolle wrote:
> > 1) So if xen_vbd_translate() fails, it can return before setting
> > preq.dev. That makes the call of pr_debug() use an uninitialized value,
> > doesn't it?
> 
> Oh yes, so it's a completely valid warning in this case!

Thanks.

Perhaps Konrad, Jan, Or Ian can tell whether the patch still needs to go
in stable as is, because the problem it fixes is more severe than the
problem it apparently creates. Maybe a mainline fix is needed before
this can go in, or perhaps even a stable specific fix (if context
changes are to blame).


Paul Bolle

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/