Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754886Ab3CDAdQ (ORCPT ); Sun, 3 Mar 2013 19:33:16 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:58067 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754624Ab3CDAdP (ORCPT ); Sun, 3 Mar 2013 19:33:15 -0500 Date: Sun, 03 Mar 2013 19:33:13 -0500 (EST) Message-Id: <20130303.193313.408641189137321065.davem@davemloft.net> To: peter@hurleysoftware.com Cc: sasha.levin@oracle.com, samuel@sortiz.org, gregkh@linuxfoundation.org, jslaby@suse.cz, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ircomm: release tty before sleeping potentially indefintely From: David Miller In-Reply-To: <1362355465.3221.82.camel@thor.lan> References: <1362350153-26225-1-git-send-email-sasha.levin@oracle.com> <20130303.174739.1195645942179862011.davem@davemloft.net> <1362355465.3221.82.camel@thor.lan> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Sun, 03 Mar 2013 16:33:18 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 609 Lines: 15 From: Peter Hurley Date: Sun, 03 Mar 2013 19:04:25 -0500 > All these are re-tested in the loop. What state test isn't repeated? One that rechecks the non-blocking filp flag, the TTY_IO_ERROR tty flag and the termios settings. Like I said, all of the state tests performed at the beginning of this function, before enterring the loop. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/