From: Arnd Bergmann <arnd@arndb.de>
To: Ley Foon Tan <lftan@altera.com>
Subject: Re: [PATCH 1/1] drivers/misc: Add Altera System ID driver
Date: Mon, 4 Mar 2013 03:32:19 +0000
User-Agent: KMail/1.12.2 (Linux/3.8.0-8-generic; KDE/4.3.2; x86_64; ; )
Cc: "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        Rob Landley <rob@landley.net>, linux-kernel@vger.kernel.org,
        linux-doc@vger.kernel.org
References: <1362366697-2768-1-git-send-email-lftan@altera.com>
In-Reply-To: <1362366697-2768-1-git-send-email-lftan@altera.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201303040332.20076.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 916
Lines: 24

On Monday 04 March 2013, Ley Foon Tan wrote:
> This patch is to add Altera System ID driver.
> User can obtain the system ID and timestamp of the system by
> reading the sysfs entry.
> 
> Usage:
> cat /sys/bus/platform/devices/[addr].sysid/sysid/id
> cat /sys/bus/platform/devices/[addr].sysid/sysid/timestamp
> 
> Signed-off-by: Ley Foon Tan <lftan@altera.com>

All sysfs files need documentation in Documentation/ABI/.

This driver looks like it should instead be using the infrastructure we
have for identifying an SoC in drivers/base/soc.c, which is currently
only used by the ARM u8500 platform but was introduced as a generic
interface for this a while ago.

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/