Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755019Ab3CDHAy (ORCPT ); Mon, 4 Mar 2013 02:00:54 -0500 Received: from shards.monkeyblade.net ([149.20.54.216]:33683 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750943Ab3CDHAx (ORCPT ); Mon, 4 Mar 2013 02:00:53 -0500 Date: Mon, 04 Mar 2013 02:00:49 -0500 (EST) Message-Id: <20130304.020049.833578984874387629.davem@davemloft.net> To: silviupopescu1990@gmail.com Cc: netdev@vger.kernel.org, sjur.brandeland@stericsson.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] CAIF: fix sparse warning for caif_usb From: David Miller In-Reply-To: <1362379920-26126-1-git-send-email-silviupopescu1990@gmail.com> References: <1362379920-26126-1-git-send-email-silviupopescu1990@gmail.com> X-Mailer: Mew version 6.5 on Emacs 24.1 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.2.7 (shards.monkeyblade.net [0.0.0.0]); Sun, 03 Mar 2013 23:00:57 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1454 Lines: 38 From: Silviu-Mihai Popescu Date: Mon, 4 Mar 2013 08:52:00 +0200 > This fixes the following sparse warning: > net/caif/caif_usb.c:84:16: warning: symbol 'cfusbl_create' was not > declared. Should it be static? > > Signed-off-by: Silviu-Mihai Popescu > --- > net/caif/caif_usb.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/net/caif/caif_usb.c b/net/caif/caif_usb.c > index 3ebc8cb..1c6ded9 100644 > --- a/net/caif/caif_usb.c > +++ b/net/caif/caif_usb.c > @@ -81,8 +81,8 @@ static void cfusbl_ctrlcmd(struct cflayer *layr, enum caif_ctrlcmd ctrl, > layr->up->ctrlcmd(layr->up, ctrl, layr->id); > } > > -struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN], > - u8 braddr[ETH_ALEN]) > +static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN], > + u8 braddr[ETH_ALEN]) Nope, that indentation isn't correct, is should be: static struct cflayer *cfusbl_create(int phyid, u8 ethaddr[ETH_ALEN], u8 braddr[ETH_ALEN]) Read my email, I said that the first character on the second line must line up with the first column after the openning parenthesis of the first line. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/