Message-ID: <1362383434.2943.5.camel@sauron>
Subject: Re: [PATCH V3 1/3] mtd: add new fields to nand_flash_dev{}
From: Artem Bityutskiy <dedekind1@gmail.com>
Reply-To: dedekind1@gmail.com
To: Huang Shijie <b32955@freescale.com>
Cc: Huang Shijie <shijie8@gmail.com>, dwmw2@infradead.org,
        computersforpeace@gmail.com, linux-mtd@lists.infradead.org,
        linux-kernel@vger.kernel.org
Date: Mon, 04 Mar 2013 09:50:34 +0200
In-Reply-To: <513437DF.2030505@freescale.com>
References: <1359349039-11510-1-git-send-email-b32955@freescale.com>
		 <1359349039-11510-2-git-send-email-b32955@freescale.com>
		 <1360684037.12703.117.camel@sauron.fi.intel.com>
		 <CAMiH66ExMK8rPMw3kvs9M2b-0ZSkfxBYteTi8QTZf+XCzJw5Dw@mail.gmail.com>
	 <1362234094.2745.9.camel@sauron> <513437DF.2030505@freescale.com>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 811
Lines: 22

On Mon, 2013-03-04 at 13:57 +0800, Huang Shijie wrote:
> The current code uses the @id to store the device id(byte 1).
> But if we use the 8 bytes id data as the keyword, and expand the @id 
> field to 8byte array,
> the device id is the second byte now. All the added zeros are for the 

I do not think you need to store the full array of ID's. Device ID's for
all the 4 of above chips are different, which is enough to distinguish
between them.

The only thing you need to add is the OOB size field to 'struct
nand_flash_dev'.

-- 
Best Regards,
Artem Bityutskiy

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/