Message-Id: <5134741702000078000C2B3E@nat28.tlf.novell.com>
Date: Mon, 04 Mar 2013 09:14:47 +0000
From: "Jan Beulich" <JBeulich@suse.com>
To: "Paul Bolle" <pebolle@tiscali.nl>
Cc: "Ian Campbell" <ian.campbell@citrix.com>,
        "Ben Hutchings" <ben@decadent.org.uk>,
        "Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
        "KonradRzeszutek Wilk" <konrad.wilk@oracle.com>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>
Subject: Re: [ 34/77] xen/blkback: Dont trust the handle from the
 frontend.
References: <20130301194351.913471337@linuxfoundation.org>
 <20130301194355.578429064@linuxfoundation.org>
 <1362172344.20156.15.camel@x61.thuisdomein>
 <1362253682.3768.136.camel@deadeye.wl.decadent.org.uk>
 <1362263724.1334.18.camel@x61.thuisdomein>
 <1362265843.3768.162.camel@deadeye.wl.decadent.org.uk>
 <1362306002.1334.29.camel@x61.thuisdomein>
 <5134617F02000078000C2AD8@nat28.tlf.novell.com>
 <1362388302.16460.5.camel@x61.thuisdomein>
In-Reply-To: <1362388302.16460.5.camel@x61.thuisdomein>
Mime-Version: 1.0
Content-Type: text/plain; charset=US-ASCII
Content-Transfer-Encoding: 8BIT
Content-Disposition: inline
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1371
Lines: 32

>>> On 04.03.13 at 10:11, Paul Bolle <pebolle@tiscali.nl> wrote:
> On Mon, 2013-03-04 at 07:55 +0000, Jan Beulich wrote:
>> >>> On 03.03.13 at 11:20, Paul Bolle <pebolle@tiscali.nl> wrote:
>> For one, a fix for the (indeed valid) compiler warning has been in
>> Konrad's tree for several days
>> 
> (http://git.kernel.org/cgit/linux/kernel/git/konrad/xen.git/commit/drivers/bl 
> ock/xen-blkback/blkback.c?id=a72d9002f80bffd7e4c7d60e5a9caa0cddffe894).
> 
> Thanks. (For the record: that commit is titled "xen/xen-blkback:
> preq.dev is used without initialized".)
> 
>> And second, there's nothing really being fixed with the patch in
>> question here. The title is kind of misleading, as the handle
>> coming from the frontend is - without said patch - in the worst
>> case being used for the very message that triggered the
>> compiler warning. Nothing else is affected, the code just gave
>> the impression that the handle was used.
>> 
>> IOW I don't see why this got proposed for stable at all.
> 
> So, you suggest to just drop this patch for v3.8.3, don't you?

I do, yes. But I'd suggest to get Konrad to agree.

Jan

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/