Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758230Ab3CDOkT (ORCPT ); Mon, 4 Mar 2013 09:40:19 -0500 Received: from mx1.redhat.com ([209.132.183.28]:18986 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758135Ab3CDOkQ (ORCPT ); Mon, 4 Mar 2013 09:40:16 -0500 From: Anton Arapov To: Anton Arapov , Oleg Nesterov , Srikar Dronamraju Cc: LKML , Josh Stone , Frank Eigler , Peter Zijlstra , Ingo Molnar , Ananth N Mavinakayanahalli Subject: [RFC PATCH v4 1/6] uretprobes: preparation patch Date: Mon, 4 Mar 2013 15:38:08 +0100 Message-Id: <1362407893-32505-2-git-send-email-anton@redhat.com> In-Reply-To: <1362407893-32505-1-git-send-email-anton@redhat.com> References: <1362407893-32505-1-git-send-email-anton@redhat.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1800 Lines: 52 1/6 and 6/6 patches are here to enclose return probes implementation as well as prohibit uprobe_register() routine with no consumer set. v3 changes: (the patch is introduced in v3) - check whether at least one of the consumer's handlers were set - a 'TODO' cap that will be removed once return probes be implemented Signed-off-by: Anton Arapov --- include/linux/uprobes.h | 1 + kernel/events/uprobes.c | 8 ++++++++ 2 files changed, 9 insertions(+) diff --git a/include/linux/uprobes.h b/include/linux/uprobes.h index 02b83db..a28bdee 100644 --- a/include/linux/uprobes.h +++ b/include/linux/uprobes.h @@ -46,6 +46,7 @@ enum uprobe_filter_ctx { struct uprobe_consumer { int (*handler)(struct uprobe_consumer *self, struct pt_regs *regs); + int (*rp_handler)(struct uprobe_consumer *self, struct pt_regs *regs); bool (*filter)(struct uprobe_consumer *self, enum uprobe_filter_ctx ctx, struct mm_struct *mm); diff --git a/kernel/events/uprobes.c b/kernel/events/uprobes.c index a567c8c..d904164 100644 --- a/kernel/events/uprobes.c +++ b/kernel/events/uprobes.c @@ -828,6 +828,14 @@ int uprobe_register(struct inode *inode, loff_t offset, struct uprobe_consumer * struct uprobe *uprobe; int ret; + /* Uprobe must have at least one set consumer */ + if (!uc->handler && !uc->rp_handler) + return -EINVAL; + + /* TODO: Implement return probes */ + if (uc->rp_handler) + return -ENOSYS; + /* Racy, just to catch the obvious mistakes */ if (offset > i_size_read(inode)) return -EINVAL; -- 1.8.1.2 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/