Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932603Ab3CDVX4 (ORCPT ); Mon, 4 Mar 2013 16:23:56 -0500 Received: from mail.us.es ([193.147.175.20]:49944 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932542Ab3CDVXv (ORCPT ); Mon, 4 Mar 2013 16:23:51 -0500 X-Qmail-Scanner-Diagnostics: from 127.0.0.1 by antivirus2 (envelope-from , uid 501) with qmail-scanner-2.10 (clamdscan: 0.97.6/16784. spamassassin: 3.3.2. Clear:RC:1(127.0.0.1):SA:0(-97.0/7.5):. Processed in 2.065728 secs); 04 Mar 2013 21:23:50 -0000 X-Envelope-From: pneira@us.es Date: Mon, 4 Mar 2013 22:23:38 +0100 From: Pablo Neira Ayuso To: Borislav Petkov , Alexandru Gheorghiu , Patrick McHardy , "David S. Miller" , netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] net: netfilter: nfnetlink: Fixed warning for nfnl_get_lock Message-ID: <20130304212338.GA3594@localhost> References: <1362426192-2921-1-git-send-email-gheorghiuandru@gmail.com> <20130304210551.GA22306@pd.tnic> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20130304210551.GA22306@pd.tnic> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1601 Lines: 43 On Mon, Mar 04, 2013 at 10:05:51PM +0100, Borislav Petkov wrote: > On Mon, Mar 04, 2013 at 09:43:11PM +0200, Alexandru Gheorghiu wrote: > > Removed unused function nfnl_get_lock which fixed the following warning: > > net/netfilter/nfnetlink.c:65:22: warning: ‘nfnl_get_lock’ defined but not used [-Wunused-function] > > > > Signed-off-by: Alexandru Gheorghiu > > --- > > net/netfilter/nfnetlink.c | 5 ----- > > 1 file changed, 5 deletions(-) > > > > diff --git a/net/netfilter/nfnetlink.c b/net/netfilter/nfnetlink.c > > index d578ec2..44aa0a7 100644 > > --- a/net/netfilter/nfnetlink.c > > +++ b/net/netfilter/nfnetlink.c > > @@ -62,11 +62,6 @@ void nfnl_unlock(__u8 subsys_id) > > } > > EXPORT_SYMBOL_GPL(nfnl_unlock); > > > > -static struct mutex *nfnl_get_lock(__u8 subsys_id) > > -{ > > - return &table[subsys_id].mutex; > > -} > > - > > I see the same warning here, gcc (Debian 4.7.2-5) 4.7.2. > > Actually this function *is* used a bit further in the same file in > nfnetlink_rcv_msg(). > > But gcc complains for some reason of which I don't even have the > slightest idea. However, if you declare the above function "static > inline..." the warning is gone. Already got a fix for compilation warning in my tree: http://1984.lsi.us.es/git/nf/commit/?id=9df9e7832391cf699abbf39fc8d95d7e78297462 Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/