Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757931Ab3CETHK (ORCPT ); Tue, 5 Mar 2013 14:07:10 -0500 Received: from mail-we0-f181.google.com ([74.125.82.181]:65527 "EHLO mail-we0-f181.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756385Ab3CETHI (ORCPT ); Tue, 5 Mar 2013 14:07:08 -0500 MIME-Version: 1.0 In-Reply-To: <878v63mwm3.fsf_-_@xmission.com> References: <20130303005700.GA32213@austin.hallyn.com> <874ngtxgt5.fsf@xmission.com> <874ngsrvrh.fsf@xmission.com> <87k3pnmwpk.fsf_-_@xmission.com> <878v63mwm3.fsf_-_@xmission.com> From: Kay Sievers Date: Tue, 5 Mar 2013 20:06:45 +0100 Message-ID: Subject: Re: [PATCH 2/2] fs: Limit sys_mount to only request filesystem modules. To: "Eric W. Biederman" Cc: Kees Cook , "Serge E. Hallyn" , LKML , Serge Hallyn , Brad Spengler , Al Viro , PaX Team , linux-fsdevel@vger.kernel.org, Linux Containers , Dave Jones Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1218 Lines: 29 On Mon, Mar 4, 2013 at 8:51 AM, Eric W. Biederman wrote: > > Modify the request_module to prefix the file system type with "fs-" > and add aliases to all of the filesystems that can be built as modules > to match. > > A common practice is to build all of the kernel code and leave code > that is not commonly needed as modules, with the result that many > users are exposed to any bug anywhere in the kernel. > > Looking for filesystems with a fs- prefix limits the pool of possible > modules that can be loaded by mount to just filesystems trivially > making things safer with no real cost. '-' is a commonly used part of a module name, and does not mix well with ramdom user provided names. We usually use ':' as the prefix separator for modaliases, when user-supplied strings are prefixed with the subsystem. I think it would be nicer to change that, and I'm sure some creative guy calls the next filesystem of the month fs-$something :) Kay -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/