Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757076Ab3CFNie (ORCPT ); Wed, 6 Mar 2013 08:38:34 -0500 Received: from arkanian.console-pimps.org ([212.110.184.194]:34636 "EHLO arkanian.console-pimps.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756816Ab3CFNiJ (ORCPT ); Wed, 6 Mar 2013 08:38:09 -0500 Message-ID: <1362577086.15011.57.camel@mfleming-mobl1.ger.corp.intel.com> Subject: Re: [PATCH] efivarfs: fix abnormal GUID in variable name by using strcpy to replace null with dash From: Matt Fleming To: Frederic Crozat Cc: joeyli , linux-efi@vger.kernel.org, linux-kernel@vger.kernel.org, Michael Schroeder , Josh Boyer , Peter Jones , Matthew Garrett Date: Wed, 06 Mar 2013 13:38:06 +0000 In-Reply-To: <1362576633.7004.69.camel@par-r81vxc7.par.novell.com> References: <1362108018-13117-1-git-send-email-jlee@suse.com> <1362151068.2842.440.camel@mfleming-mobl1.ger.corp.intel.com> <1362155493.2842.446.camel@mfleming-mobl1.ger.corp.intel.com> <1362181299.23932.168.camel@linux-s257.site> <1362555258.23932.573.camel@linux-s257.site> <1362568750.15011.24.camel@mfleming-mobl1.ger.corp.intel.com> <1362571097.7004.66.camel@par-r81vxc7.par.novell.com> <1362573401.15011.48.camel@mfleming-mobl1.ger.corp.intel.com> <1362576633.7004.69.camel@par-r81vxc7.par.novell.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.4.4 (3.4.4-2.fc17) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1791 Lines: 44 On Wed, 2013-03-06 at 14:30 +0100, Frederic Crozat wrote: > Le mercredi 06 mars 2013 à 12:36 +0000, Matt Fleming a écrit : > > On Wed, 2013-03-06 at 12:58 +0100, Frederic Crozat wrote: > > > Le mercredi 06 mars 2013 à 11:19 +0000, Matt Fleming a écrit : > > > > > > > Also, which machine did you see this behaviour on? > > > > > > HP z220 desktop, System BIOS K51 v 1.54 > > > > > > this issue is only the "Secure Boot" related variables, which make me > > > think HP incorrectly created them in their latest firmware (where they > > > added Windows 8 support). > > > > Are you saying that the behaviour regarding VariableNameSize changes > > depending on which variable is returned? > > > > Mercy..... > > Well, I only get the error message for some variables (8), not all of > them. > > It was quite visible on unpatched kernel, with ls > -d /sys/firmware/efi/vars. > > ls -d /sys/firmware/efi/vars/*8be4d* | grep -v -- -8be returns > /sys/firmware/efi/vars/dbxDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c > /sys/firmware/efi/vars/KEKDefault-pport8be4df61-93ca-11d2-aa0d-00e098032b8c > /sys/firmware/efi/vars/SecureBoot-pport8be4df61-93ca-11d2-aa0d-00e098032b8c > /sys/firmware/efi/vars/SetupMode-Information8be4df61-93ca-11d2-aa0d-00e098032b8c > /sys/firmware/efi/vars/SignatureSupport-pport8be4df61-93ca-11d2-aa0d-00e098032b8c > /sys/firmware/efi/vars/VendorKeys-pport8be4df61-93ca-11d2-aa0d-00e098032b8c > > All other variable names were fine. Interesting. Thanks. -- Matt Fleming, Intel Open Source Technology Center -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/