Date: Wed, 6 Mar 2013 17:39:10 +0000
From: Russell King - ARM Linux <linux@arm.linux.org.uk>
To: Andrew Cooks <acooks@gmail.com>
Cc: Dan Williams <djbw@fb.com>, Vinod Koul <vinod.koul@intel.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Jassi Brar <jassisinghbrar@gmail.com>,
        open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH][v2] check for dma mapping error in ioat_dma_self_test
Message-ID: <20130306173910.GU17833@n2100.arm.linux.org.uk>
References: <CAJtEV7bGjdJdCsKZ05+FbzoNDeMd2YUh=B=qc=ev_Z2ESg7vPQ@mail.gmail.com> <1362536245-4708-1-git-send-email-acooks@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1362536245-4708-1-git-send-email-acooks@gmail.com>
User-Agent: Mutt/1.5.19 (2009-01-05)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 878
Lines: 22

Thanks for redoing the patch, but...

On Wed, Mar 06, 2013 at 10:17:22AM +0800, Andrew Cooks wrote:
> diff --git a/drivers/dma/ioat/dma.c b/drivers/dma/ioat/dma.c
> index 1879a59..5431ba8 100644
> --- a/drivers/dma/ioat/dma.c
> +++ b/drivers/dma/ioat/dma.c
> @@ -832,7 +832,18 @@ int ioat_dma_self_test(struct ioatdma_device *device)
>  	}
>  
>  	dma_src = dma_map_single(dev, src, IOAT_TEST_SIZE, DMA_TO_DEVICE);
> +	if (dma_mapping_error(dev, dma_src)) {
> +		dev_err(dev, "dma mapping failed.\n");
> +		goto free_resources;

Won't this result in 'err' still being zero here, and cause this function
to apparantly return success?
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/