Date: Wed, 06 Mar 2013 15:38:41 -0500 (EST)
Message-Id: <20130306.153841.784919874486534382.davem@davemloft.net>
To: bhavesh@vmware.com
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        pv-drivers@vmware.com, sbhatewara@vmware.com
Subject: Re: [PATCH net-next] vmxnet3: prevent div-by-zero panic when ring
 resizing uninitialized dev
From: David Miller <davem@davemloft.net>
In-Reply-To: <1362591984-16587-1-git-send-email-bhavesh@vmware.com>
References: <1362591984-16587-1-git-send-email-bhavesh@vmware.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1338
Lines: 33

From: Bhavesh Davda <bhavesh@vmware.com>
Date: Wed,  6 Mar 2013 09:46:24 -0800

> Linux is free to call ethtool ops as soon as a netdev exists when probe
> finishes. However, we only allocate vmxnet3 tx/rx queues and initialize the
> rx_buf_per_pkt field in struct vmxnet3_adapter when the interface is
> opened (UP).
> 
> Signed-off-by: Bhavesh Davda <bhavesh@vmware.com>
> Signed-off-by: Shreyas N Bhatewara <sbhatewara@vmware.com>
> ---
>  drivers/net/vmxnet3/vmxnet3_drv.c     |    3 ++-
>  drivers/net/vmxnet3/vmxnet3_ethtool.c |    6 ++++++
>  drivers/net/vmxnet3/vmxnet3_int.h     |    4 ++--
>  3 files changed, 10 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/net/vmxnet3/vmxnet3_drv.c b/drivers/net/vmxnet3/vmxnet3_drv.c
> index 4aad350..bfc5898 100644
> --- a/drivers/net/vmxnet3/vmxnet3_drv.c
> +++ b/drivers/net/vmxnet3/vmxnet3_drv.c
> @@ -2922,7 +2922,7 @@ vmxnet3_probe_device(struct pci_dev *pdev,
>  				    (int)num_online_cpus());
>  	else
>  #endif
> -		num_rx_queues = 1;
> +	num_rx_queues = 1;

Why are you un-indenting this else branch?  Please don't do that.
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/