Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755236Ab3CFUoH (ORCPT ); Wed, 6 Mar 2013 15:44:07 -0500 Received: from terminus.zytor.com ([198.137.202.10]:47125 "EHLO mail.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753539Ab3CFUoG (ORCPT ); Wed, 6 Mar 2013 15:44:06 -0500 User-Agent: K-9 Mail for Android In-Reply-To: References: <20130228205206.GC3438@sgi.com> <512FC697.3090608@zytor.com> <20130228210910.GD3438@sgi.com> <512FC82B.40909@zytor.com> <512FE3AE.4070903@zytor.com> <20130305081519.GA19165@sgi.com> <9bcd6241-37fd-4ae9-a997-2a5da1eaf997@email.android.com> <51377C3A.3030301@zytor.com> <51377ED7.1060800@zytor.com> MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Subject: Re: Revert commit 5dcd14ecd4 - breaks EFI boot with SLES11 elilo.efi From: "H. Peter Anvin" Date: Wed, 06 Mar 2013 12:43:39 -0800 To: Josh Boyer CC: Yinghai Lu , Robin Holt , linux-kernel@vger.kernel.org, pjones@redhat.com Message-ID: <414399ca-2000-4120-88fb-af1d203990eb@email.android.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1606 Lines: 42 Yeah. I'll queue it up today and send to Linus in the next batch. Josh Boyer wrote: >On Wed, Mar 6, 2013 at 12:37 PM, H. Peter Anvin wrote: >> On 03/06/2013 09:36 AM, Josh Boyer wrote: >>> >>> Something like this? >>> >>> Index: linux-2.6/arch/x86/include/asm/bootparam_utils.h >>> =================================================================== >>> --- linux-2.6.orig/arch/x86/include/asm/bootparam_utils.h >>> +++ linux-2.6/arch/x86/include/asm/bootparam_utils.h >>> @@ -20,8 +20,11 @@ static void sanitize_boot_params(struct >>> if (boot_params->sentinel) { >>> /*fields in boot_params are not valid, clear them */ >>> memset(&boot_params->olpc_ofw_header, 0, >>> - (char *)&boot_params->alt_mem_k - >>> + (char *)&boot_params->efi_info - >>> (char *)&boot_params->olpc_ofw_header); >>> memset(&boot_params->kbd_status, 0, >>> (char *)&boot_params->hdr - >>> (char *)&boot_params->kbd_status); >>> >>> I can try that in a bit. >>> >> >> Right. > >OK. Doing that on top of 3.9-rc1 results in me having a booting >machine >again. I'd suggest we get that into upstream quick-ish. > >josh -- Sent from my mobile phone. Please excuse brevity and lack of formatting. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/