Message-ID: <5137CE7E.8050403@linux.vnet.ibm.com>
Date: Wed, 06 Mar 2013 15:17:18 -0800
From: Dave Hansen <dave@linux.vnet.ibm.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/17.0 Thunderbird/17.0
MIME-Version: 1.0
To: Tetsuo Handa <penguin-kernel@i-love.sakura.ne.jp>
CC: bp@alien8.de, hpa@linux.intel.com, linux-kernel@vger.kernel.org
Subject: Re: [3.9-rc1 x86] Bug in ioremap code?
References: <201303060041.AIF15342.tJFOHLQFFOMVSO@I-love.SAKURA.ne.jp> <20130305180650.GD4914@pd.tnic> <201303060628.CBG00578.OJtMFFHLQVSFOO@I-love.SAKURA.ne.jp> <51367104.5050200@linux.vnet.ibm.com>	<20130305224432.GD27022@pd.tnic> <201303062358.EFG90616.HLtSQFJFOMVOFO@I-love.SAKURA.ne.jp> <5137822F.2030501@linux.vnet.ibm.com> <513787BB.4040504@linux.vnet.ibm.com>
In-Reply-To: <513787BB.4040504@linux.vnet.ibm.com>
Content-Type: text/plain; charset=ISO-8859-1
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1350
Lines: 29

On 03/06/2013 10:15 AM, Dave Hansen wrote:
> Does anybody know what this business is in __cpa_process_fault()?
> 
>>         /*
>>          * Ignore the NULL PTE for kernel identity mapping, as it is expected
>>          * to have holes.
>>          * Also set numpages to '1' indicating that we processed cpa req for
>>          * one virtual address page and its pfn. TBD: numpages can be set based
>>          * on the initial value and the level returned by lookup_address().
>>          */
> 
> If this is expecting the identity mapping to have holes, then the
> BUG_ON() is wrong.  But how would it _get_ holes?

The holes in question were part of the PCI space.  The ioremap code was
trying to keep the kernel identity map in sync with the mappings that it
had made.  But, in the process, it called __pa() on a virtual address
that was part of one of those holes.  I'm not _quite_ sure what the
fallout is from trying to sync a nonexistent map, but it surely wasn't
an intended or good thing to be doing.

A patch to fix it should be on the way.  Tetsuo, can you apply it and
see if it helps you?

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/