Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932228Ab3CGBb4 (ORCPT ); Wed, 6 Mar 2013 20:31:56 -0500 Received: from mail-da0-f47.google.com ([209.85.210.47]:48854 "EHLO mail-da0-f47.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751543Ab3CGBbz (ORCPT ); Wed, 6 Mar 2013 20:31:55 -0500 Date: Thu, 7 Mar 2013 09:30:42 +0800 From: Greg Kroah-Hartman To: David Brown Cc: linux-kernel@vger.kernel.org, linux-arm-msm@vger.kernel.org, linux-arm-kernel@lists.infradead.org Subject: Re: [PATCH 3/6] ssbi: Fix exit mismatch in remove function Message-ID: <20130307013042.GB2910@kroah.com> References: <1362616187-21089-1-git-send-email-davidb@codeaurora.org> <1362616187-21089-4-git-send-email-davidb@codeaurora.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362616187-21089-4-git-send-email-davidb@codeaurora.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 36 On Wed, Mar 06, 2013 at 04:29:44PM -0800, David Brown wrote: > msm_ssbi_remove is referenced with __exit_p, but not declared with > __exit. This causes a warning when the driver is not built as a > module: > > drivers/ssbi/ssbi.c:341:23: warning: 'msm_ssbi_remove' defined but not used [-Wunused-function] > > Fix by adding the __exit declaration to the function. > > Signed-off-by: David Brown > --- > drivers/ssbi/ssbi.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/ssbi/ssbi.c b/drivers/ssbi/ssbi.c > index 86d8416..4d503da 100644 > --- a/drivers/ssbi/ssbi.c > +++ b/drivers/ssbi/ssbi.c > @@ -337,7 +337,7 @@ err_get_mem_res: > return ret; > } > > -static int msm_ssbi_remove(struct platform_device *pdev) > +static int __exit msm_ssbi_remove(struct platform_device *pdev) No, remove the __exit_p marking instead, unless you want your kernel to be oopsed :) thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/