Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759141Ab3CGEjs (ORCPT ); Wed, 6 Mar 2013 23:39:48 -0500 Received: from mail-pa0-f48.google.com ([209.85.220.48]:36502 "EHLO mail-pa0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754551Ab3CGEjr (ORCPT ); Wed, 6 Mar 2013 23:39:47 -0500 Date: Thu, 7 Mar 2013 12:39:38 +0800 From: Shaohua Li To: CAI Qian Cc: linux-mm , linux-kernel , Hugh Dickins , Rik van Riel , Sasha Levin , Andrew Morton , Linus Torvalds Subject: Re: change of behavior for madvise in 3.9-rc1 Message-ID: <20130307043938.GA4393@kernel.org> References: <1543700056.10481632.1362628775559.JavaMail.root@redhat.com> <1648837228.10483479.1362629104045.JavaMail.root@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1648837228.10483479.1362629104045.JavaMail.root@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1574 Lines: 31 On Wed, Mar 06, 2013 at 11:05:04PM -0500, CAI Qian wrote: > Bisecting indicated that this commit, > 1998cc048901109a29924380b8e91bc049b32951 > mm: make madvise(MADV_WILLNEED) support swap file prefetch > > Caused an LTP test failure, > http://goo.gl/1FVPy > > madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory > madvise02 5 TFAIL : madvise succeeded unexpectedly > > While it passed without the above commit > madvise02 1 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 2 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 3 TPASS : failed as expected: TEST_ERRNO=EINVAL(22): Invalid argument > madvise02 4 TPASS : failed as expected: TEST_ERRNO=ENOMEM(12): Cannot allocate memory > madvise02 5 TPASS : failed as expected: TEST_ERRNO=EBADF(9): Bad file descriptor I thought this is expected behavior. madvise(MADV_WILLNEED) to anonymous memory doesn't return -EBADF now, as now we support swap prefretch. Thanks, Shaohua -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/