Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751325Ab3CGF3w (ORCPT ); Thu, 7 Mar 2013 00:29:52 -0500 Received: from devils.ext.ti.com ([198.47.26.153]:39327 "EHLO devils.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750800Ab3CGF3t convert rfc822-to-8bit (ORCPT ); Thu, 7 Mar 2013 00:29:49 -0500 From: "Hiremath, Vaibhav" To: "Porter, Matt" , "Krishnamoorthy, Balaji T" , Chris Ball , "Cousson, Benoit" , Tony Lindgren , Russell King CC: Devicetree Discuss , Linux ARM Kernel List , Linux OMAP List , Linux Kernel Mailing List , Linux MMC List Subject: RE: [PATCH 2/2] ARM: dts: add AM33XX MMC support Thread-Topic: [PATCH 2/2] ARM: dts: add AM33XX MMC support Thread-Index: AQHOGuqV346jkMSBUUmpAvXZrfaGX5iZsVbQ Date: Thu, 7 Mar 2013 05:29:24 +0000 Message-ID: <79CD15C6BA57404B839C016229A409A83EC20028@DBDE01.ent.ti.com> References: <1362629799-22485-1-git-send-email-mporter@ti.com> <1362629799-22485-3-git-send-email-mporter@ti.com> In-Reply-To: <1362629799-22485-3-git-send-email-mporter@ti.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.24.170.142] Content-Type: text/plain; charset="Windows-1252" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 4231 Lines: 153 > -----Original Message----- > From: linux-omap-owner@vger.kernel.org [mailto:linux-omap- > owner@vger.kernel.org] On Behalf Of Porter, Matt > Sent: Thursday, March 07, 2013 9:47 AM > To: Krishnamoorthy, Balaji T; Chris Ball; Cousson, Benoit; Tony > Lindgren; Russell King > Cc: Devicetree Discuss; Linux ARM Kernel List; Linux OMAP List; Linux > Kernel Mailing List; Linux MMC List > Subject: [PATCH 2/2] ARM: dts: add AM33XX MMC support > > Adds AM33XX MMC support for am335x-bone, am335x-evm, and > am335x-evmsk. > > Signed-off-by: Matt Porter > Acked-by: Tony Lindgren > --- > arch/arm/boot/dts/am335x-bone.dts | 7 +++++++ > arch/arm/boot/dts/am335x-evm.dts | 7 +++++++ > arch/arm/boot/dts/am335x-evmsk.dts | 7 +++++++ > arch/arm/boot/dts/am33xx.dtsi | 28 ++++++++++++++++++++++++++++ > 4 files changed, 49 insertions(+) > > diff --git a/arch/arm/boot/dts/am335x-bone.dts > b/arch/arm/boot/dts/am335x-bone.dts > index 11b240c..a154ce0 100644 > --- a/arch/arm/boot/dts/am335x-bone.dts > +++ b/arch/arm/boot/dts/am335x-bone.dts > @@ -120,6 +120,8 @@ > }; > > ldo3_reg: regulator@5 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > > @@ -136,3 +138,8 @@ > &cpsw_emac1 { > phy_id = <&davinci_mdio>, <1>; > }; > + > +&mmc1 { > + status = "okay"; > + vmmc-supply = <&ldo3_reg>; > +}; > diff --git a/arch/arm/boot/dts/am335x-evm.dts > b/arch/arm/boot/dts/am335x-evm.dts > index d649644..2907da6 100644 > --- a/arch/arm/boot/dts/am335x-evm.dts > +++ b/arch/arm/boot/dts/am335x-evm.dts > @@ -232,6 +232,8 @@ > }; > > vmmc_reg: regulator@12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > }; > @@ -244,3 +246,8 @@ > &cpsw_emac1 { > phy_id = <&davinci_mdio>, <1>; > }; > + > +&mmc1 { > + status = "okay"; > + vmmc-supply = <&vmmc_reg>; > +}; > diff --git a/arch/arm/boot/dts/am335x-evmsk.dts > b/arch/arm/boot/dts/am335x-evmsk.dts > index f5a6162..f050c46 100644 > --- a/arch/arm/boot/dts/am335x-evmsk.dts > +++ b/arch/arm/boot/dts/am335x-evmsk.dts > @@ -244,7 +244,14 @@ > }; > > vmmc_reg: regulator@12 { > + regulator-min-microvolt = <1800000>; > + regulator-max-microvolt = <3300000>; > regulator-always-on; > }; > }; > }; > + > +&mmc1 { > + status = "okay"; > + vmmc-supply = <&vmmc_reg>; > +}; > diff --git a/arch/arm/boot/dts/am33xx.dtsi > b/arch/arm/boot/dts/am33xx.dtsi > index c3c781a..e029eea 100644 > --- a/arch/arm/boot/dts/am33xx.dtsi > +++ b/arch/arm/boot/dts/am33xx.dtsi > @@ -234,6 +234,34 @@ > status = "disabled"; > }; > > + mmc1: mmc@48060000 { > + compatible = "ti,omap3-hsmmc"; > + ti,hwmods = "mmc1"; > + ti,dual-volt; > + ti,needs-special-reset; > + dmas = <&edma 24 > + &edma 25>; > + dma-names = "tx", "rx"; > + status = "disabled"; > + }; > + > + mmc2: mmc@481d8000 { > + compatible = "ti,omap3-hsmmc"; > + ti,hwmods = "mmc2"; > + ti,needs-special-reset; > + dmas = <&edma 2 > + &edma 3>; > + dma-names = "tx", "rx"; > + status = "disabled"; > + }; > + > + mmc3: mmc@47810000 { > + compatible = "ti,omap3-hsmmc"; > + ti,hwmods = "mmc3"; > + ti,needs-special-reset; > + status = "disabled"; > + }; Any specific reason why you did not add edma entry here as well? Also, I wonder why "interrupt" property is not coming here, I understand That hwmod is filling the gap here; but I would still recommend you to complete The DT node, as we only support DT boot. I will test the whole patch series today and update you. Thanks, Vaibhav > + > wdt2: wdt@44e35000 { > compatible = "ti,omap3-wdt"; > ti,hwmods = "wd_timer2"; > -- > 1.7.9.5 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-omap" > in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/