Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755955Ab3CGKF6 (ORCPT ); Thu, 7 Mar 2013 05:05:58 -0500 Received: from arroyo.ext.ti.com ([192.94.94.40]:46471 "EHLO arroyo.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752314Ab3CGKF5 (ORCPT ); Thu, 7 Mar 2013 05:05:57 -0500 Message-ID: <5138666E.6090201@ti.com> Date: Thu, 7 Mar 2013 15:35:34 +0530 From: Sekhar Nori User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:17.0) Gecko/20130215 Thunderbird/17.0.3 MIME-Version: 1.0 To: Greg Kroah-Hartman CC: David Brown , , Kenneth Heitke , , Subject: Re: [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver References: <1362616187-21089-1-git-send-email-davidb@codeaurora.org> <1362616187-21089-2-git-send-email-davidb@codeaurora.org> <20130307013008.GA2910@kroah.com> <8yawqtjvl8y.fsf@huya.qualcomm.com> <20130307060117.GA31687@kroah.com> In-Reply-To: <20130307060117.GA31687@kroah.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1261 Lines: 33 On 3/7/2013 11:31 AM, Greg Kroah-Hartman wrote: > On Wed, Mar 06, 2013 at 09:20:45PM -0800, David Brown wrote: >> Greg Kroah-Hartman writes: >> >>> On Wed, Mar 06, 2013 at 04:29:42PM -0800, David Brown wrote: >>>> +menu "Qualcomm MSM SSBI bus support" >>>> + depends on ARCH_MSM >>> >>> Why? >> >> In the sense that ARCH_MSM are the only devices that ever were, or ever >> will be made with this device. It doesn't strictly depend on it, but do >> we want to clutter the config for everything else. > > It's not "clutter". You want me to build this on other platforms, to > catch api and other types of build breakages. This is the way for > almost all Linux drivers. Not having a depends on helps build coverage, but I have seen objections to showing up irrelevant configurations to users (of x86 for example). See one here from Linus for OMAP_OCP2SCP http://lkml.indiana.edu/hypermail/linux/kernel/1210.0/00785.html If this case is different, I am not sure why. Thanks, Sekhar -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/