Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752741Ab3CGMar (ORCPT ); Thu, 7 Mar 2013 07:30:47 -0500 Received: from mail-ie0-f172.google.com ([209.85.223.172]:42931 "EHLO mail-ie0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750817Ab3CGMaq (ORCPT ); Thu, 7 Mar 2013 07:30:46 -0500 MIME-Version: 1.0 In-Reply-To: <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> References: <1362626715-6549-1-git-send-email-wenyou.yang@atmel.com> <1362626815-6628-1-git-send-email-wenyou.yang@atmel.com> Date: Thu, 7 Mar 2013 13:30:45 +0100 Message-ID: Subject: Re: [PATCH v6 01/16] spi/spi-atmel: fix probing failure after xfer->speed_hz set From: Joachim Eastwood To: Wenyou Yang Cc: linux-arm-kernel@lists.infradead.org, grant.likely@secretlab.ca, nicolas.ferre@atmel.com, plagnioj@jcrosoft.com, richard.genoud@gmail.com, JM.Lin@atmel.com, spi-devel-general@lists.sourceforge.net, linux-kernel@vger.kernel.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1613 Lines: 41 On 7 March 2013 04:26, Wenyou Yang wrote: > commit: 059b8ffeee5b427949872bb6ed5db5ae0788054e > cause the atmel spi probing failure. > > Signed-off-by: Wenyou Yang > Cc: spi-devel-general@lists.sourceforge.net > Cc: linux-kernel@vger.kernel.org > --- > drivers/spi/spi-atmel.c | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > > diff --git a/drivers/spi/spi-atmel.c b/drivers/spi/spi-atmel.c > index 656d137..1eca815 100644 > --- a/drivers/spi/spi-atmel.c > +++ b/drivers/spi/spi-atmel.c > @@ -846,9 +846,9 @@ static int atmel_spi_transfer(struct spi_device *spi, struct spi_message *msg) > } > } > > - /* FIXME implement these protocol options!! */ > - if (xfer->speed_hz) { > - dev_dbg(&spi->dev, "no protocol options yet\n"); > + if (xfer->speed_hz < spi->max_speed_hz) { > + dev_dbg(&spi->dev, > + "speed in transfer less than bus speed\n"); > return -ENOPROTOOPT; > } I sent a similar patch to spi-devl a while ago, which Grant said he applied. https://patchwork.kernel.org/patch/2165301/ Can't find the patch in any upstream git tree so I guess Grant hasn't pushed it yet. regards Joachim Eastwood -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/