Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758275Ab3CGO0v (ORCPT ); Thu, 7 Mar 2013 09:26:51 -0500 Received: from cantor2.suse.de ([195.135.220.15]:38594 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755185Ab3CGO0t (ORCPT ); Thu, 7 Mar 2013 09:26:49 -0500 Date: Thu, 7 Mar 2013 15:26:48 +0100 (CET) From: Jiri Kosina To: Benjamin Tissoires Cc: Benjamin Tissoires , Henrik Rydberg , Stephane Chatty , David Herrmann , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC 1/2] HID: Extend the interface with idle requests In-Reply-To: <1361979498-24446-2-git-send-email-benjamin.tissoires@redhat.com> Message-ID: References: <1361979498-24446-1-git-send-email-benjamin.tissoires@redhat.com> <1361979498-24446-2-git-send-email-benjamin.tissoires@redhat.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1265 Lines: 34 On Wed, 27 Feb 2013, Benjamin Tissoires wrote: > Some drivers send the idle command directly to underlying device, > creating an unwanted dependency on the underlying transport layer. > This patch adds hid_hw_idle() to the interface, thereby removing > usbhid from the lion share of the drivers. > > Signed-off-by: Benjamin Tissoires > --- > drivers/hid/usbhid/hid-core.c | 15 +++++++++++++++ > include/linux/hid.h | 19 +++++++++++++++++++ > 2 files changed, 34 insertions(+) > > diff --git a/drivers/hid/usbhid/hid-core.c b/drivers/hid/usbhid/hid-core.c > index 420466b..effcd3d 100644 > --- a/drivers/hid/usbhid/hid-core.c > +++ b/drivers/hid/usbhid/hid-core.c > @@ -1253,6 +1253,20 @@ static void usbhid_request(struct hid_device *hid, struct hid_report *rep, int r > } > } > > +static int usbhid_idle(struct hid_device *hid, int report, int idle, > + int reqtype) Where does the need for passing the report argument come from please? -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/