Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933112Ab3CGSb6 (ORCPT ); Thu, 7 Mar 2013 13:31:58 -0500 Received: from mx1.redhat.com ([209.132.183.28]:39318 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932152Ab3CGSb5 (ORCPT ); Thu, 7 Mar 2013 13:31:57 -0500 Message-ID: <5138DCE9.1010204@redhat.com> Date: Thu, 07 Mar 2013 13:31:05 -0500 From: Don Dutile User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:10.0.5) Gecko/20120601 Thunderbird/10.0.5 MIME-Version: 1.0 To: "Li, Zhen-Hua" , iommu@lists.linux-foundation.org CC: linux-kernel@vger.kernel.org, Joerg Roedel , Ingo Molnar , Suresh Siddha , Hannes Reinecke Subject: Re: [PATCH 1/1] iommu: add a dma remap fault reason. References: <1362537797-6034-1-git-send-email-zhen-hual@hp.com> In-Reply-To: <1362537797-6034-1-git-send-email-zhen-hual@hp.com> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1562 Lines: 43 cc-ing the upstream iommu-list On 03/05/2013 09:43 PM, Li, Zhen-Hua wrote: > The number of dma fault reasons in intel's document are from 1 to 0xD, but in dmar.c I cannot find fault reason 0xD. > > In this document: > Intel Virtualization Technology for Directed I/O Architecture Specification > http://download.intel.com/technology/computing/vptech/Intel(r)_VT_for_Direct_IO.pdf > > Chapter 4. Support For Device-IOTLBs > > Table 6. Unsuccessful Translated Requests > > There is fault reason for 0xD not listed in kernel: > Present context-entry used to process translation request > specifies blocking of Translation Requests (Translation Type (T) > field value not equal to 01b). > > So I think 0xD should be added. > > Signed-off-by: Li, Zhen-Hua > --- > drivers/iommu/dmar.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/iommu/dmar.c b/drivers/iommu/dmar.c > index dc7e478..e5cdaf8 100644 > --- a/drivers/iommu/dmar.c > +++ b/drivers/iommu/dmar.c > @@ -1083,6 +1083,7 @@ static const char *dma_remap_fault_reasons[] = > "non-zero reserved fields in RTP", > "non-zero reserved fields in CTP", > "non-zero reserved fields in PTE", > + "PCE for translation request specifies blocking", > }; > > static const char *irq_remap_fault_reasons[] = -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/