Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759706Ab3CGSpW (ORCPT ); Thu, 7 Mar 2013 13:45:22 -0500 Received: from wolverine02.qualcomm.com ([199.106.114.251]:54679 "EHLO wolverine02.qualcomm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755969Ab3CGSpU (ORCPT ); Thu, 7 Mar 2013 13:45:20 -0500 X-IronPort-AV: E=Sophos;i="4.84,803,1355126400"; d="scan'208";a="28081192" From: David Brown To: Sekhar Nori Cc: Greg Kroah-Hartman , , Kenneth Heitke , , Subject: Re: [PATCH 1/6] platform-drivers: msm: add single-wire serial bus interface (SSBI) driver References: <1362616187-21089-1-git-send-email-davidb@codeaurora.org> <1362616187-21089-2-git-send-email-davidb@codeaurora.org> <20130307013008.GA2910@kroah.com> <8yawqtjvl8y.fsf@huya.qualcomm.com> <20130307060117.GA31687@kroah.com> <5138666E.6090201@ti.com> Date: Thu, 07 Mar 2013 10:45:19 -0800 In-Reply-To: <5138666E.6090201@ti.com> (Sekhar Nori's message of "Thu, 7 Mar 2013 15:35:34 +0530") Message-ID: <8yak3pjuk00.fsf@huya.qualcomm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1711 Lines: 44 Sekhar Nori writes: > On 3/7/2013 11:31 AM, Greg Kroah-Hartman wrote: >> On Wed, Mar 06, 2013 at 09:20:45PM -0800, David Brown wrote: >>> Greg Kroah-Hartman writes: >>> >>>> On Wed, Mar 06, 2013 at 04:29:42PM -0800, David Brown wrote: >>>>> +menu "Qualcomm MSM SSBI bus support" >>>>> + depends on ARCH_MSM >>>> >>>> Why? >>> >>> In the sense that ARCH_MSM are the only devices that ever were, or ever >>> will be made with this device. It doesn't strictly depend on it, but do >>> we want to clutter the config for everything else. >> >> It's not "clutter". You want me to build this on other platforms, to >> catch api and other types of build breakages. This is the way for >> almost all Linux drivers. > > Not having a depends on helps build coverage, but I have seen > objections to showing up irrelevant configurations to users (of x86 for > example). See one here from Linus for OMAP_OCP2SCP > > http://lkml.indiana.edu/hypermail/linux/kernel/1210.0/00785.html > > If this case is different, I am not sure why. This was, in fact, the reason I put the dependency there. I found it a little annoying being asked about a bunch of OMAP devices when building the x86 kernel. At least they weren't cancer curing options (default y). David -- sent by an employee of the Qualcomm Innovation Center, Inc. The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum, hosted by The Linux Foundation -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/