Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933398Ab3CGVHZ (ORCPT ); Thu, 7 Mar 2013 16:07:25 -0500 Received: from mail-qa0-f44.google.com ([209.85.216.44]:65030 "EHLO mail-qa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756847Ab3CGVHX (ORCPT ); Thu, 7 Mar 2013 16:07:23 -0500 From: Jean-Francois Dagenais To: zbr@ioremap.net, linux-kernel@vger.kernel.org Cc: olivier@okprods.com, Jean-Francois Dagenais Subject: [PATCH 2/2] w1: ds2408: use ARRAY_SIZE instead of hard-coded number Date: Thu, 7 Mar 2013 16:07:04 -0500 Message-Id: <1362690424-324-2-git-send-email-jeff.dagenais@gmail.com> X-Mailer: git-send-email 1.8.1.1 In-Reply-To: <1362690424-324-1-git-send-email-jeff.dagenais@gmail.com> References: <47BBCF14-C7BC-4C35-826A-52A50EFB8B4B@sonatest.com> <1362690424-324-1-git-send-email-jeff.dagenais@gmail.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1456 Lines: 46 Signed-off-by: Jean-Francois Dagenais --- drivers/w1/slaves/w1_ds2408.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/w1/slaves/w1_ds2408.c b/drivers/w1/slaves/w1_ds2408.c index 25a5168..e45eca1 100644 --- a/drivers/w1/slaves/w1_ds2408.c +++ b/drivers/w1/slaves/w1_ds2408.c @@ -303,8 +303,7 @@ error: -#define NB_SYSFS_BIN_FILES 6 -static struct bin_attribute w1_f29_sysfs_bin_files[NB_SYSFS_BIN_FILES] = { +static struct bin_attribute w1_f29_sysfs_bin_files[] = { { .attr = { .name = "state", @@ -363,7 +362,7 @@ static int w1_f29_add_slave(struct w1_slave *sl) int err = 0; int i; - for (i = 0; i < NB_SYSFS_BIN_FILES && !err; ++i) + for (i = 0; i < ARRAY_SIZE(w1_f29_sysfs_bin_files) && !err; ++i) err = sysfs_create_bin_file( &sl->dev.kobj, &(w1_f29_sysfs_bin_files[i])); @@ -377,7 +376,7 @@ static int w1_f29_add_slave(struct w1_slave *sl) static void w1_f29_remove_slave(struct w1_slave *sl) { int i; - for (i = NB_SYSFS_BIN_FILES - 1; i >= 0; --i) + for (i = ARRAY_SIZE(w1_f29_sysfs_bin_files) - 1; i >= 0; --i) sysfs_remove_bin_file(&sl->dev.kobj, &(w1_f29_sysfs_bin_files[i])); } -- 1.8.1.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/