Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760054Ab3CGXbO (ORCPT ); Thu, 7 Mar 2013 18:31:14 -0500 Received: from mail-pb0-f49.google.com ([209.85.160.49]:54697 "EHLO mail-pb0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755935Ab3CGXbM (ORCPT ); Thu, 7 Mar 2013 18:31:12 -0500 Date: Fri, 8 Mar 2013 07:31:16 +0800 From: Greg Kroah-Hartman To: Tejun Heo Cc: Kay Sievers , linux-kernel@vger.kernel.org, laijs@cn.fujitsu.com, axboe@kernel.dk, jmoyer@redhat.com, zab@redhat.com Subject: Re: [PATCH 30/31] driver/base: implement subsys_virtual_register() Message-ID: <20130307233116.GF10304@kroah.com> References: <1362194662-2344-1-git-send-email-tj@kernel.org> <1362194662-2344-31-git-send-email-tj@kernel.org> <20130302181727.GB2051@kroah.com> <20130305204327.GK12795@htj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130305204327.GK12795@htj.dyndns.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1809 Lines: 41 On Tue, Mar 05, 2013 at 12:43:27PM -0800, Tejun Heo wrote: > On Sun, Mar 03, 2013 at 07:42:31AM +0100, Kay Sievers wrote: > > On Sat, Mar 2, 2013 at 7:17 PM, Greg Kroah-Hartman > > wrote: > > > On Fri, Mar 01, 2013 at 07:24:21PM -0800, Tejun Heo wrote: > > >> Kay tells me the most appropriate place to expose workqueues to > > >> userland would be /sys/devices/virtual/workqueues/WQ_NAME which is > > >> symlinked to /sys/bus/workqueue/devices/WQ_NAME and that we're lacking > > >> a way to do that outside of driver core as virtual_device_parent() > > >> isn't exported and there's no inteface to conveniently create a > > >> virtual subsystem. > > > > > > I'm almost afraid to ask what you want to export to userspace for a > > > workqueue that userspace would care about... > > > > > > If you create a subsystem, the devices will show up under the virtual > > > "bus" if you don't give them a parent, so this patch shouldn't be > > > needed, unless you are abusing the driver model. What am I missing > > > here? > > > > Unfortunately, the parent == NULL --> /sys/devices/virtual// > > we have only implemented for classes, and not for buses. We should fix > > that. > > Greg, how should I proceed on this? As I wrote before, I don't really > care about where or how. As long as I can make workqueues visible to > userland, I'm happy. Sorry for the delay, I'm at a conference all this week, and haven't had much time to think about this. If Kay says this is ok for now, that's good enough for me. thanks, greg k-h -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/