Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932149Ab3CGXzs (ORCPT ); Thu, 7 Mar 2013 18:55:48 -0500 Received: from mail-ve0-f182.google.com ([209.85.128.182]:60911 "EHLO mail-ve0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758816Ab3CGXzr (ORCPT ); Thu, 7 Mar 2013 18:55:47 -0500 MIME-Version: 1.0 In-Reply-To: References: <20130307021645.GA10173@redhat.com> <20130307153052.GA18246@redhat.com> <20130307193501.GA2802@redhat.com> <20130307221800.GA572@redhat.com> Date: Thu, 7 Mar 2013 15:55:46 -0800 X-Google-Sender-Auth: KoFOynKYFGybvfEfD_rnWrZ2dzo Message-ID: Subject: Re: BUG_ON(nd->inode->i_op->follow_link); From: Linus Torvalds To: Dave Jones , Linus Torvalds , Linux Kernel , Al Viro Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 897 Lines: 21 On Thu, Mar 7, 2013 at 2:50 PM, Linus Torvalds wrote: > > Al, I think the BUG_ON() is simply bogus. Should we just remove it? Or > is there some conceptual reason why we can't handle a symlink there? Hmm. Removing the BUG_ON() makes things work. Sure, you can get odd files that are symlinks, but that's kind of what you ask for when you do that whole O_NOFOLLOW thing, so the fact that you can then get them through opening the /proc//fd/ file would seem to be roughly the right thing regardless. So I think I'll queue up that removal, although I'd still be happier with input from Al. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/