Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751631Ab3CHF1c (ORCPT ); Fri, 8 Mar 2013 00:27:32 -0500 Received: from mail-ie0-f179.google.com ([209.85.223.179]:62799 "EHLO mail-ie0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750956Ab3CHF13 (ORCPT ); Fri, 8 Mar 2013 00:27:29 -0500 MIME-Version: 1.0 In-Reply-To: References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-2-git-send-email-yinghai@kernel.org> <20130308051059.GC14556@mtj.dyndns.org> Date: Thu, 7 Mar 2013 21:27:28 -0800 X-Google-Sender-Auth: 1OYR2ClgtXk1Fnjj1W75fFgWe5E Message-ID: Subject: Re: [PATCH 01/14] x86, ACPI, mm: Kill max_low_pfn_mapped From: Yinghai Lu To: Tejun Heo Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , Daniel Vetter , David Airlie , Jacob Shin , linux-acpi@vger.kernel.org, dri-devel@lists.freedesktop.org Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1455 Lines: 35 On Thu, Mar 7, 2013 at 9:25 PM, Tejun Heo wrote: > On Thu, Mar 7, 2013 at 9:22 PM, Yinghai Lu wrote: >> On Thu, Mar 7, 2013 at 9:10 PM, Tejun Heo wrote: >>> On Thu, Mar 07, 2013 at 08:58:27PM -0800, Yinghai Lu wrote: >>>> diff --git a/drivers/gpu/drm/i915/i915_gem_stolen.c b/drivers/gpu/drm/i915/i915_gem_stolen.c >>>> index 69d97cb..7f9380b 100644 >>>> --- a/drivers/gpu/drm/i915/i915_gem_stolen.c >>>> +++ b/drivers/gpu/drm/i915/i915_gem_stolen.c >>>> @@ -81,7 +81,7 @@ static unsigned long i915_stolen_to_physical(struct drm_device *dev) >>>> base -= dev_priv->mm.gtt->stolen_size; >>>> } else { >>>> /* Stolen is immediately above Top of Memory */ >>>> - base = max_low_pfn_mapped << PAGE_SHIFT; >>>> + base = __REMOVED_CRAZY__ << PAGE_SHIFT; >>> >>> Huh? >> >> Whole function: > > Yeah, but can't we still just do 1LLU << 32 like other places? Or at > least explain what was there before? It's gonna confuse the hell out > of future readers of the code. They are not using memblock_find_in_range(), so 1ULL<< will not help. Really hope i915 drm guys could clean that hacks. Thanks Yinghai -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/