Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933783Ab3CHHIv (ORCPT ); Fri, 8 Mar 2013 02:08:51 -0500 Received: from mail-pb0-f48.google.com ([209.85.160.48]:33543 "EHLO mail-pb0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752129Ab3CHHIt (ORCPT ); Fri, 8 Mar 2013 02:08:49 -0500 Date: Thu, 7 Mar 2013 23:08:45 -0800 From: Tejun Heo To: Yinghai Lu Cc: Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Andrew Morton , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH 03/14] x86, ACPI: store override acpi tables phys addr Message-ID: <20130308070845.GP14556@mtj.dyndns.org> References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-4-git-send-email-yinghai@kernel.org> <20130308053653.GE14556@mtj.dyndns.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1341 Lines: 33 On Thu, Mar 07, 2013 at 10:49:04PM -0800, Yinghai Lu wrote: > >> @@ -654,10 +654,13 @@ void __init acpi_initrd_override_copy(void) > >> arch_reserve_mem_area(acpi_tables_addr, all_tables_size); > >> > >> for (no = 0; no < table_nr; no++) { > >> - size_t size = early_initrd_files[no].size; > >> + unsigned long size = early_initrd_files[no].size; > >> > >> p = early_ioremap(acpi_tables_addr + total_offset, size); > >> - memcpy(p, early_initrd_files[no].data, size); > >> + q = early_ioremap((unsigned long)early_initrd_files[no].data, > >> + size); > >> + memcpy(p, q, size); > >> + early_iounmap(q, size); > > > > Ah, okay, so the loop change in the previous patch was for this, I > > suppose? That chunk probably should either be a separate patch or > > rolled into this one. > > merge two patches? Hmm... probably better to just move the related chunks from the previous patch to this one with better explanation on what's going on. Thanks. -- tejun -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/