Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754399Ab3CHHP6 (ORCPT ); Fri, 8 Mar 2013 02:15:58 -0500 Received: from mail.linuxfoundation.org ([140.211.169.12]:44378 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753976Ab3CHHP5 (ORCPT ); Fri, 8 Mar 2013 02:15:57 -0500 Date: Thu, 7 Mar 2013 23:16:11 -0800 From: Andrew Morton To: Yinghai Lu Cc: Tejun Heo , "Yu, Fenghua" , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , Thomas Renninger , Tang Chen , linux-kernel@vger.kernel.org, Pekka Enberg , Jacob Shin , "Rafael J. Wysocki" , linux-acpi@vger.kernel.org Subject: Re: [PATCH 04/14] x86, ACPI: make acpi override finding work with 32bit flat mode Message-Id: <20130307231611.5fd2bdcb.akpm@linux-foundation.org> In-Reply-To: References: <1362718720-27048-1-git-send-email-yinghai@kernel.org> <1362718720-27048-5-git-send-email-yinghai@kernel.org> <20130308055023.GF14556@mtj.dyndns.org> X-Mailer: Sylpheed 2.7.1 (GTK+ 2.18.9; x86_64-redhat-linux-gnu) Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1566 Lines: 34 On Thu, 7 Mar 2013 22:57:21 -0800 Yinghai Lu wrote: > > > >> @@ -552,38 +552,47 @@ u8 __init acpi_table_checksum(u8 *buffer, u32 length) > >> return sum; > >> } > >> > >> -/* All but ACPI_SIG_RSDP and ACPI_SIG_FACS: */ > >> -static const char * const table_sigs[] = { > >> - ACPI_SIG_BERT, ACPI_SIG_CPEP, ACPI_SIG_ECDT, ACPI_SIG_EINJ, > >> - ACPI_SIG_ERST, ACPI_SIG_HEST, ACPI_SIG_MADT, ACPI_SIG_MSCT, > >> - ACPI_SIG_SBST, ACPI_SIG_SLIT, ACPI_SIG_SRAT, ACPI_SIG_ASF, > >> - ACPI_SIG_BOOT, ACPI_SIG_DBGP, ACPI_SIG_DMAR, ACPI_SIG_HPET, > >> - ACPI_SIG_IBFT, ACPI_SIG_IVRS, ACPI_SIG_MCFG, ACPI_SIG_MCHI, > >> - ACPI_SIG_SLIC, ACPI_SIG_SPCR, ACPI_SIG_SPMI, ACPI_SIG_TCPA, > >> - ACPI_SIG_UEFI, ACPI_SIG_WAET, ACPI_SIG_WDAT, ACPI_SIG_WDDT, > >> - ACPI_SIG_WDRT, ACPI_SIG_DSDT, ACPI_SIG_FADT, ACPI_SIG_PSDT, > >> - ACPI_SIG_RSDT, ACPI_SIG_XSDT, ACPI_SIG_SSDT, NULL }; > > > > Why is this table made a stack variable? What's the benefit of doing > > that? > > so I do need to switch global variables to phys and access it. What Tejun means is that it should be marked "static" within acpi_initrd_override(), so we don't have to build a copy on the stack at runtime each time acpi_initrd_override() is called. While we're there, it should be __initdata also. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/