Date: Fri, 8 Mar 2013 08:29:34 +0100
From: Thierry Reding <thierry.reding@avionic-design.de>
To: Andrew Chew <achew@nvidia.com>
Cc: acourbot@nvidia.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/1 v5] pwm_bl: Add support for backlight enable regulator
Message-ID: <20130308072934.GC5772@avionic-0098.mockup.avionic-design.de>
References: <1362690968-24854-1-git-send-email-achew@nvidia.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="i7F3eY7HS/tUJxUd"
Content-Disposition: inline
In-Reply-To: <1362690968-24854-1-git-send-email-achew@nvidia.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1779
Lines: 46


--i7F3eY7HS/tUJxUd
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Thu, Mar 07, 2013 at 01:16:08PM -0800, Andrew Chew wrote:
> The backlight enable regulator is specified in the device tree node for
> backlight.
>=20
> Signed-off-by: Andrew Chew <achew@nvidia.com>

This looks good in general. I'd like to see Alex' comment addressed and
perhaps the commit message shouldn't be device tree specific, since the
same can be done with legacy board setup code. It would be nice if it'd
mention something about why the regulator is added.

Thierry

--i7F3eY7HS/tUJxUd
Content-Type: application/pgp-signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2.0.19 (GNU/Linux)

iQIcBAEBAgAGBQJROZNeAAoJEN0jrNd/PrOhxOwP/3AQL/s5gB1Ea/EapbAr5nnI
uX9v+uzbyFjRp5OTVwwum1XNBh3LHfRg2A/r2PUudzO6sTqVfww3gbayf8kujYLX
plnEPrwdIKDruu4v0Y29y+FIz8R5EoyZwMMGb/ZKjlwMJPmdgU54yyzGdrGKcasf
ZmOA4YLXQzXCt62dupDr3sphIeNS2N215rGGwSEPR0tbOAabHsi1p3Du7jz/Dr9L
pVrRcy5IwoiOHF3N9csYtOToCsy8E5p1uplfFdRCtRMtRMmvNo9kon46nvz3WJaR
qRZfG+5qTA8pPDgKtBpjHZCIjDbqGc0h3VAgtxvvkYn07AGdGVQq4wJ/mQk3xAAU
gbExlJyRwgEQflMhYYDKSQO4996Hb7i+X/cKiFEInqaEcfGSZ1fDWvt4SaJ9Bz5N
L6FT9FpU6Ac5elGGtkdic7pKISUy7rX2MdPvBVQRYN9ZuLWhMS2iqyM2IOC4T/ek
BBumKkJ5e/GP4Uwxepa8VO0rmD9eJYqc20MFLRxaDtXUZvbsXkiMf9o0/63ggbfn
QKpFNjY0N1vzsyArhiFKNNprpdy01X3JYa4uL4I0ppo5EMHbp3l94TEQbILz0RHU
PjjliGjJRbG1sziP7Mf3+8LKOMW96rhjG3pnqwxdtbAlYis+J1XkUei/2nYD2DGh
zfwKyI4XG+BEFfe1IYu9
=J1w3
-----END PGP SIGNATURE-----

--i7F3eY7HS/tUJxUd--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/