Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933938Ab3CHJPr (ORCPT ); Fri, 8 Mar 2013 04:15:47 -0500 Received: from multi.imgtec.com ([194.200.65.239]:17848 "EHLO multi.imgtec.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932815Ab3CHJPo (ORCPT ); Fri, 8 Mar 2013 04:15:44 -0500 Message-ID: <5139AC39.90805@imgtec.com> Date: Fri, 8 Mar 2013 09:15:37 +0000 From: James Hogan User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130110 Thunderbird/17.0.2 MIME-Version: 1.0 To: Rusty Russell CC: Al Viro , Michal Marek , "Andrew Morton" , Guenter Roeck , Jean Delvare , , , Mike Frysinger , , Subject: Re: [RFC -next] linux/linkage.h: fix symbol prefix handling References: <1362656642-2693-1-git-send-email-james.hogan@imgtec.com> <87sj46wyf2.fsf@rustcorp.com.au> In-Reply-To: <87sj46wyf2.fsf@rustcorp.com.au> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [192.168.154.65] X-SEF-Processed: 7_3_0_01181__2013_03_08_09_15_38 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1052 Lines: 27 Hi Rusty, On 08/03/13 00:03, Rusty Russell wrote: > James Hogan writes: >> Also the definition of SYMBOL_PREFIX in is removed as >> it conflicts, isn't used anywhere, and is defined as a string so differs >> from the assembly definition. > > So now, if CONFIG_SYMBOL_PREFIX, SYMBOL_PREFIX is defined on the cmdline > as a string. Otherwise it's empty (not the empty string?): No, SYMBOL_PREFIX is now defined as a non-string, same as asm files, but the now unused definition in linux/kernel.h did define it as a string as it used CONFIG_SYMBOL_PREFIX which is a string. When I said "and is defined as a string" I was referring to the one in linux/kernel.h that this removes. Does that make sense? It's all a bit messy unfortunately (hence RFC). Cheers James -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/