Message-ID: <1362754537.4219.24.camel@thor.lan>
Subject: Re: [PATCH 10/16] TTY: cleanup tty->hw_stopped uses
From: Peter Hurley <peter@hurleysoftware.com>
To: Jiri Slaby <jslaby@suse.cz>
Cc: Jiri Slaby <jirislaby@gmail.com>, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org
Date: Fri, 08 Mar 2013 09:55:37 -0500
In-Reply-To: <5139F9B2.1070909@suse.cz>
References: <1362658360-26629-1-git-send-email-jslaby@suse.cz>
	  <1362658360-26629-10-git-send-email-jslaby@suse.cz>
	 <1362753564.4219.17.camel@thor.lan> <5139F9B2.1070909@suse.cz>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1575
Lines: 43

On Fri, 2013-03-08 at 15:46 +0100, Jiri Slaby wrote:
> On 03/08/2013 03:39 PM, Peter Hurley wrote:
> > On Thu, 2013-03-07 at 13:12 +0100, Jiri Slaby wrote:
> >> --- a/drivers/net/caif/caif_serial.c
> >> +++ b/drivers/net/caif/caif_serial.c
> >> @@ -88,7 +88,6 @@ static inline void update_tty_status(struct ser_device *ser)
> >>  {
> >>  	ser->tty_status =
> >>  		ser->tty->stopped << 5 |
> >> -		ser->tty->hw_stopped << 4 |
> >>  		ser->tty->flow_stopped << 3 |
> >>  		ser->tty->packet << 2 |
> >>  		ser->tty->port->low_latency << 1 |
> > 
> > I would maybe leave this with a code comment instead.
> > 
> > 		ser->tty->hw_stopped << 4 |      /* hw_stopped is not used by tty layer */
> 
> Yeah, maybe...

Plus this is documented in Documentation/networking/caif/README

> >> @@ -4256,9 +4251,6 @@ static void seq_line_info(struct seq_file *m, struct e100_serial *info)
> >>  		if (info->port.tty->stopped)
> >>  			seq_printf(m, " stopped:%i",
> >>  				   (int)info->port.tty->stopped);
> >> -		if (info->port.tty->hw_stopped)
> >> -			seq_printf(m, " hw_stopped:%i",
> >> -				   (int)info->port.tty->hw_stopped);
> > 
> > User-space visible. Tool may expect this field.
> 
> I thought that on the first glance too. But look what does that whole
> seq_printf depend on.

Oh, right, duh. That field's never been printed :)


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/