From: Arnd Bergmann <arnd@arndb.de>
To: Davide Ciminaghi <ciminaghi@gnudd.com>
Subject: Re: [PATCH 2/3] x86, pci sta2x11-fixup: add function to access sta2x11 instance id
Date: Fri, 8 Mar 2013 16:13:34 +0000
User-Agent: KMail/1.12.2 (Linux/3.8.0-8-generic; KDE/4.3.2; x86_64; ; )
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com, x86@kernel.org,
        rubini@gnudd.com, sameo@linux.intel.com, giancarlo.asnaghi@st.com,
        mturquette@linaro.org, linus.walleij@linaro.org,
        rob.herring@calxeda.com, broonie@opensource.wolfsonmicro.com,
        linux-kernel@vger.kernel.org
References: <1362756691-14736-1-git-send-email-ciminaghi@gnudd.com> <1362756691-14736-3-git-send-email-ciminaghi@gnudd.com>
In-Reply-To: <1362756691-14736-3-git-send-email-ciminaghi@gnudd.com>
MIME-Version: 1.0
Content-Type: Text/Plain;
  charset="iso-8859-15"
Content-Transfer-Encoding: 7bit
Message-Id: <201303081613.34371.arnd@arndb.de>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 710
Lines: 18

On Friday 08 March 2013, Davide Ciminaghi wrote:
> 
> The sta2x11 instance id will be included in clock names to make them
> unique in case of multiple sta2x11's living on the same machine.
> 
> Signed-off-by: Davide Ciminaghi <ciminaghi@gnudd.com>

I might be missing something, but this seems counterintuitive. Shouldn't
the clock names really be constant and independent of the instance?

The instance should be identified already by the dev_name, right?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/