Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760031Ab3CHSvH (ORCPT ); Fri, 8 Mar 2013 13:51:07 -0500 Received: from mail-ee0-f54.google.com ([74.125.83.54]:44834 "EHLO mail-ee0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751082Ab3CHSvF (ORCPT ); Fri, 8 Mar 2013 13:51:05 -0500 MIME-Version: 1.0 In-Reply-To: <20130308150408.GA25399@redhat.com> References: <20130307021645.GA10173@redhat.com> <20130308150408.GA25399@redhat.com> Date: Fri, 8 Mar 2013 10:51:03 -0800 X-Google-Sender-Auth: qSVFUpOAv9t0RjQBahZ5U6tpA_E Message-ID: Subject: Re: BUG_ON(nd->inode != parent->d_inode); From: Linus Torvalds To: Dave Jones , Linux Kernel , Al Viro , Linus Torvalds Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1411 Lines: 40 On Fri, Mar 8, 2013 at 7:04 AM, Dave Jones wrote: > > Managed to trigger this one from a different path.. > > kernel BUG at fs/namei.c:1439! > Call Trace: > [] path_lookupat+0x71e/0x740 > [] filename_lookup+0x34/0xc0 > [] user_path_at_empty+0x8e/0x110 > [] user_path_at+0x11/0x20 > [] sys_lgetxattr+0x37/0xa0 > [] system_call_fastpath+0x16/0x1b > > What can I dump here that might give us more clues ? I think we should do the same thing and print out dentry names to give us clues about where in /proc the problem happens. And it doesn't really have to be proc - because of the symlinks in /proc, we could easily get to /sys through processes like udev etc.. So how about just replaving that BUG_ON() with a if (WARN_ON(nd->inode != parent->d_inode)) { printk("%s -> %s (%s)\n", parent->d_name.name, path->dentry->d_name.name, nd->last.name); return -EINVAL; } or something like that. Hopefully that gives some clue about whare it happens, and some idea about what migth be going on.. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/