Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1760103Ab3CHXzU (ORCPT ); Fri, 8 Mar 2013 18:55:20 -0500 Received: from mx1.redhat.com ([209.132.183.28]:63502 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756564Ab3CHXzS (ORCPT ); Fri, 8 Mar 2013 18:55:18 -0500 Date: Fri, 8 Mar 2013 18:55:14 -0500 From: Dave Jones To: Linus Torvalds Cc: Linux Kernel , Al Viro Subject: Re: BUG_ON(nd->inode != parent->d_inode); Message-ID: <20130308235514.GA5605@redhat.com> Mail-Followup-To: Dave Jones , Linus Torvalds , Linux Kernel , Al Viro References: <20130308191804.GA9774@redhat.com> <20130308192042.GA10305@redhat.com> <20130308193652.GA11692@redhat.com> <20130308210432.GA21500@redhat.com> <20130308230734.GA28317@redhat.com> <20130308233041.GA32587@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1439 Lines: 27 On Fri, Mar 08, 2013 at 03:45:37PM -0800, Linus Torvalds wrote: > On Fri, Mar 8, 2013 at 3:30 PM, Dave Jones wrote: > > [ 100.729401] nd->last.name = (\xffffffd2.W._.N.".\xfffffffe.\xffffff80.^N.?.\xffffffe4.E.8.g.\xffffffd2.N.\xffffffb6.^G.\xfffffff1.\xffffffcc.U.\xffffffda.^_.h.^M.1.\xffffffc5.\xffffff82.%.B.\xffffffe0.\xffffffad.^U.8.^L.c.Z.^K.\xffffffe4.h.J.\xffffffc8.\xffffffad.\xffffff83./.\xffffff80.\xffffffd1.\xffffffe5.\xffffff87.\xffffffc3.\xffffffb2.\xffffffdc.\xffffff9d.\xffffffd1.E.\xffffffab.^B. > > You're printing out a 'char' with %02x, aren't you? And then the sign > extensions gives you six extra 'f' character every time the char is > negative. > > If using %02x, make sure you use 'unsigned char', or "& 255". > > Depending on just what is going on, the "nd->last.name" thing really > is probably a valid string. Strictly speaking it's not necessarily > NUL-terminated, though, and should be printed out to a maximum of > "nd->last.len" characters (but the whole path will be NUL-terminated, > so it's all ok, you just might print out more than one component) > > Linus That one was printed out with %s Dave -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/