Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933704Ab3CIDBI (ORCPT ); Fri, 8 Mar 2013 22:01:08 -0500 Received: from mail-pb0-f52.google.com ([209.85.160.52]:54751 "EHLO mail-pb0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932716Ab3CIDBF (ORCPT ); Fri, 8 Mar 2013 22:01:05 -0500 Message-ID: <513AA5ED.2030300@linaro.org> Date: Sat, 09 Mar 2013 04:01:01 +0100 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130221 Thunderbird/17.0.3 MIME-Version: 1.0 To: Chuansheng Liu CC: lenb@kernel.org, len.brown@intel.com, linux-pm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 3/3] intel_idle: set the state_tables array as __initdata to save mem References: <1362674529.31506.17.camel@cliu38-desktop-build> <1362754926.31506.42.camel@cliu38-desktop-build> <1362755169.31506.47.camel@cliu38-desktop-build> In-Reply-To: <1362755169.31506.47.camel@cliu38-desktop-build> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1121 Lines: 30 On 03/08/2013 04:06 PM, Chuansheng Liu wrote: > > Currently, in intel_idle.c, there are 5 state_tables array, every > array size is sizeof(struct cpuidle_state) * CPUIDLE_STATE_MAX. > > As in intel_idle_cpuidle_driver_init(), we have copied the data into > intel_idle_driver->state[], so do not need to keep state_tables[] > there any more after system init. > > It will save about 3~4k memory, also benefits mobile devices. > Here changing them as __initdata, also removing global var > cpuidle_state_table pointer. > > Signed-off-by: liu chuansheng > --- Acked-by: Daniel Lezcano -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/