Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751523Ab3CIUSz (ORCPT ); Sat, 9 Mar 2013 15:18:55 -0500 Received: from mx1.redhat.com ([209.132.183.28]:57289 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751327Ab3CIUSy (ORCPT ); Sat, 9 Mar 2013 15:18:54 -0500 Date: Sat, 9 Mar 2013 21:17:04 +0100 From: Oleg Nesterov To: Lucas De Marchi Cc: lucas.de.marchi@gmail.com, David Howells , James Morris , Andrew Morton , linux-kernel@vger.kernel.org Subject: Re: [PATCH v2 1/7] kernel/sys.c: Use the simpler call_usermodehelper() Message-ID: <20130309201704.GA16399@redhat.com> References: <1362723313-839-1-git-send-email-lucas.demarchi@profusion.mobi> <1362723313-839-2-git-send-email-lucas.demarchi@profusion.mobi> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1362723313-839-2-git-send-email-lucas.demarchi@profusion.mobi> User-Agent: Mutt/1.5.18 (2008-05-17) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1174 Lines: 40 On 03/08, Lucas De Marchi wrote: > > Commit "7ff6764 usermodehelper: cleanup/fix __orderly_poweroff() && > argv_free()" simplified __orderly_poweroff() removing the need to use > call_usermodehelper_fns(). > > Since we are not passing any callback, it's simpler to use > call_usermodehelper(). > > Signed-off-by: Lucas De Marchi Reviewed-by: Oleg Nesterov > --- > kernel/sys.c | 3 +-- > 1 file changed, 1 insertion(+), 2 deletions(-) > > diff --git a/kernel/sys.c b/kernel/sys.c > index 81f5644..bd15276 100644 > --- a/kernel/sys.c > +++ b/kernel/sys.c > @@ -2203,8 +2203,7 @@ static int __orderly_poweroff(void) > return -ENOMEM; > } > > - ret = call_usermodehelper_fns(argv[0], argv, envp, UMH_WAIT_EXEC, > - NULL, NULL, NULL); > + ret = call_usermodehelper(argv[0], argv, envp, UMH_WAIT_EXEC); > argv_free(argv); > > return ret; > -- > 1.8.1.5 > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/