Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751753Ab3CIVeg (ORCPT ); Sat, 9 Mar 2013 16:34:36 -0500 Received: from out1-smtp.messagingengine.com ([66.111.4.25]:50266 "EHLO out1-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751491Ab3CIVed (ORCPT ); Sat, 9 Mar 2013 16:34:33 -0500 X-Sasl-enc: cBQbEJxsOX7aTr9VEGocW9LosGH7RFBelljG9sTb5SFA 1362864871 Date: Sat, 9 Mar 2013 18:34:28 -0300 From: Henrique de Moraes Holschuh To: Mandeep Singh Baines Cc: Oleg Nesterov , Linux Kernel Mailing List , linux-acpi@vger.kernel.org, ibm-acpi@hmh.eng.br, ibm-acpi-devel@lists.sourceforge.net, platform-driver-x86@vger.kernel.org, Aaron Lu , Tejun Heo , Andrew Morton , Artem Savkov Subject: Re: [PATCH 1/1] thinkpad-acpi: kill hotkey_thread_mutex Message-ID: <20130309213428.GB7559@khazad-dum.debian.net> References: <20130305174838.GA7276@redhat.com> <20130305180542.GA12738@redhat.com> <20130305232603.GA16045@khazad-dum.debian.net> <20130306154420.GA7697@redhat.com> <20130306233232.GA12645@khazad-dum.debian.net> <20130307175305.GA15631@redhat.com> <20130307175359.GB15631@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: X-GPG-Fingerprint: 1024D/1CDB0FE3 5422 5C61 F6B7 06FB 7E04 3738 EE25 DE3F 1CDB 0FE3 User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1160 Lines: 27 On Thu, 07 Mar 2013, Mandeep Singh Baines wrote: > On Thu, Mar 7, 2013 at 9:53 AM, Oleg Nesterov wrote: > > hotkey_kthread() does try_to_freeze() under hotkey_thread_mutex. > > > > We can simply kill this mutex, hotkey_poll_stop_sync() does not need > > to serialize with hotkey_kthread(). When kthread_stop() returns the > > thread is already dead, it called do_exit()->complete_vfork_done(). > > > > Reported-by: Artem Savkov > > Reported-by: Maciej Rutecki > > Signed-off-by: Oleg Nesterov > > > > Reviewed-by: Mandeep Singh Baines Acked-by: Henrique de Moraes Holschuh -- "One disk to rule them all, One disk to find them. One disk to bring them all and in the darkness grind them. In the Land of Redmond where the shadows lie." -- The Silicon Valley Tarot Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/