Date: Sun, 10 Mar 2013 05:38:44 -0700
From: Tejun Heo <tj@kernel.org>
To: Lai Jiangshan <laijs@cn.fujitsu.com>
Cc: linux-kernel@vger.kernel.org, axboe@kernel.dk, jmoyer@redhat.com,
        zab@redhat.com
Subject: Re: [PATCH 12/31] workqueue: update synchronization rules on
 workqueue->pwqs
Message-ID: <20130310123844.GE24522@htj.dyndns.org>
References: <1362194662-2344-1-git-send-email-tj@kernel.org>
 <1362194662-2344-13-git-send-email-tj@kernel.org>
 <513C5BD8.9050909@cn.fujitsu.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <513C5BD8.9050909@cn.fujitsu.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1045
Lines: 42

Hello, Lai.

On Sun, Mar 10, 2013 at 06:09:28PM +0800, Lai Jiangshan wrote:
> >  #define for_each_pwq(pwq, wq)						\
> > -	list_for_each_entry((pwq), &(wq)->pwqs, pwqs_node)
> > +	list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node)		\
> > +		if (({ assert_rcu_or_wq_lock(); true; }))
> 
> Aware this:
> 
> if (somecondition)
> 	for_each_pwq(pwq, wq)
> 		one_statement;q
> else
> 	xxxxx;
> 
> 
> for_each_pwq() will eat the else.

Yeah, but that will also generate a compiler warning.

> To avoid this, you can use:
> 
> #define for_each_pwq(pwq, wq)						\
> 	list_for_each_entry_rcu((pwq), &(wq)->pwqs, pwqs_node)		\
> 		if (({ assert_rcu_or_wq_lock(); false; })) { }		\
> 		else
> 
> 
> The same for for_each_pool() in later patch.

Ooh, yeah, that's better.  Will do that.

Thanks.

-- 
tejun
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/