Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752063Ab3CKFG1 (ORCPT ); Mon, 11 Mar 2013 01:06:27 -0400 Received: from comal.ext.ti.com ([198.47.26.152]:45347 "EHLO comal.ext.ti.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751305Ab3CKFGW (ORCPT ); Mon, 11 Mar 2013 01:06:22 -0400 From: Lokesh Vutla To: , , CC: , , Lokesh Vutla Subject: [PATCH 1/8] memory: emif: Correct the lpmode timeout calculation Date: Mon, 11 Mar 2013 10:35:58 +0530 Message-ID: <1362978365-5593-2-git-send-email-lokeshvutla@ti.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1362978365-5593-1-git-send-email-lokeshvutla@ti.com> References: <1362978365-5593-1-git-send-email-lokeshvutla@ti.com> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1020 Lines: 34 The driver tries to round up the specified timeout cycles to the next power of 2 value. But this is done wrongly. Correcting this here. Reported-by: Nishanth Menon Signed-off-by: Lokesh Vutla --- drivers/memory/emif.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/memory/emif.c b/drivers/memory/emif.c index df08736..622638c 100644 --- a/drivers/memory/emif.c +++ b/drivers/memory/emif.c @@ -732,9 +732,9 @@ static u32 get_pwr_mgmt_ctrl(u32 freq, struct emif_data *emif, u32 ip_rev) if (timeout < 16) { timeout = 0; } else { - timeout = __fls(timeout) - 3; if (timeout & (timeout - 1)) - timeout++; + timeout <<= 1; + timeout = __fls(timeout) - 3; } switch (lpmode) { -- 1.7.9.5 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/