Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752204Ab3CKPKN (ORCPT ); Mon, 11 Mar 2013 11:10:13 -0400 Received: from mail-vb0-f41.google.com ([209.85.212.41]:60896 "EHLO mail-vb0-f41.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751122Ab3CKPKM (ORCPT ); Mon, 11 Mar 2013 11:10:12 -0400 MIME-Version: 1.0 In-Reply-To: <20130311003530.GE21522@ZenIV.linux.org.uk> References: <20130307213819.GB19543@redhat.com> <20130307220333.GA31039@redhat.com> <20130307223610.GA2494@redhat.com> <20130308145306.GA24085@redhat.com> <20130310221047.GA21522@ZenIV.linux.org.uk> <20130311003530.GE21522@ZenIV.linux.org.uk> Date: Mon, 11 Mar 2013 08:10:10 -0700 X-Google-Sender-Auth: Mdtbv7xFh4OvBmgbr-lwUNfTInc Message-ID: Subject: Re: pipe_release oops. From: Linus Torvalds To: Al Viro Cc: Dave Jones , Linux Kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 926 Lines: 19 On Sun, Mar 10, 2013 at 5:35 PM, Al Viro wrote: > > Hmm... How the devil would things like pipe_read_open() get called, anyway? > pipe_rdwr_open() can be called, all right - that happens if you do pipe() > and then open() via /proc/self/fd/. But how could pipe_read_open() and > pipe_write_open() be called? They are accessible only as ->open() of > read_pipefifo_fops/write_pipefifo_fops. And those are only used by > fifo_open(), which does reassign file->f_op to them, but does *not* call > their ->open()... .. same deal? Open the resulting fd from /proc/self/fd/ afterwards, which will call file->f_op->open(), no? Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/