Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753976Ab3CKQyr (ORCPT ); Mon, 11 Mar 2013 12:54:47 -0400 Received: from mail-lb0-f179.google.com ([209.85.217.179]:60648 "EHLO mail-lb0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753086Ab3CKQyp (ORCPT ); Mon, 11 Mar 2013 12:54:45 -0400 MIME-Version: 1.0 In-Reply-To: <513BECDA.3030803@asianux.com> References: <513BECDA.3030803@asianux.com> Date: Mon, 11 Mar 2013 17:54:43 +0100 Message-ID: Subject: Re: [PATCH] ARM:net: an issue for k which is u32, never < 0 From: Mircea Gherzan To: Chen Gang Cc: Russell King - ARM Linux , nschichan@freebox.fr, daniel.borkmann@tik.ee.ethz.ch, David Miller , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org >> linux-kernel@vger.kernel.org" Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1244 Lines: 31 2013/3/10 Chen Gang : > > k is u32 which never < 0, need type cast, or cause issue. > > Signed-off-by: Chen Gang > --- > arch/arm/net/bpf_jit_32.c | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > > diff --git a/arch/arm/net/bpf_jit_32.c b/arch/arm/net/bpf_jit_32.c > index 6828ef6..a0bd8a7 100644 > --- a/arch/arm/net/bpf_jit_32.c > +++ b/arch/arm/net/bpf_jit_32.c > @@ -576,7 +576,7 @@ load_ind: > /* x = ((*(frame + k)) & 0xf) << 2; */ > ctx->seen |= SEEN_X | SEEN_DATA | SEEN_CALL; > /* the interpreter should deal with the negative K */ > - if (k < 0) > + if ((int)k < 0) > return -1; > /* offset in r1: we might have to take the slow path */ > emit_mov_i(r_off, k, ctx); > -- > 1.7.7.6 Acked-by: Mircea Gherzan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/