Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753247Ab3CKRSn (ORCPT ); Mon, 11 Mar 2013 13:18:43 -0400 Received: from avon.wwwdotorg.org ([70.85.31.133]:60862 "EHLO avon.wwwdotorg.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753913Ab3CKRSl (ORCPT ); Mon, 11 Mar 2013 13:18:41 -0400 Message-ID: <513E11EE.1020405@wwwdotorg.org> Date: Mon, 11 Mar 2013 11:18:38 -0600 From: Stephen Warren User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-Version: 1.0 To: Laxman Dewangan CC: Thierry Reding , "akpm@linux-foundation.org" , "a.zummo@towertech.it" , "rtc-linux@googlegroups.com" , "linux-tegra@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH V2 2/5] rtc: tegra: Use struct dev_pm_ops for power management References: <1362991468-30226-1-git-send-email-ldewangan@nvidia.com> <1362991468-30226-3-git-send-email-ldewangan@nvidia.com> <20130311085132.GA7900@avionic-0098.mockup.avionic-design.de> <513D9C48.8090505@nvidia.com> In-Reply-To: <513D9C48.8090505@nvidia.com> X-Enigmail-Version: 1.4.6 Content-Type: text/plain; charset=ISO-8859-1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1238 Lines: 32 On 03/11/2013 02:56 AM, Laxman Dewangan wrote: > On Monday 11 March 2013 02:21 PM, Thierry Reding wrote: >> * PGP Signed by an unknown key >> >> On Mon, Mar 11, 2013 at 02:14:25PM +0530, Laxman Dewangan wrote: >> [...] >>> diff --git a/drivers/rtc/rtc-tegra.c b/drivers/rtc/rtc-tegra.c >> [...] >>> @@ -431,6 +430,8 @@ static int tegra_rtc_resume(struct >>> platform_device *pdev) >>> } >>> #endif >>> +SIMPLE_DEV_PM_OPS(tegra_rtc_pm_ops, tegra_rtc_suspend, >>> tegra_rtc_resume); >> I should've been more explicit. Since you had this marked as static in >> the previous patch, this needs to be static SIMPLE_DEV_PM_OPS. > Yaah, I should keep the static. > > I think I will need to respin this patch only in place of whole series. > > Andrew, > > Let me know if this is fine. In general, it's much easier if you repost a whole series. Otherwise, you make the maintainer manually piece together the series from bits of V2 and bits of V3, which is harder than just grabbing all of V3. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/